New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 883591 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

fullscreen/full-screen-inline-split-crash.html in webkit_layout_tests failing on chromium.webkit/WebKit Android (Nexus4)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Sep 13

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of peria@chromium.org

fullscreen/full-screen-inline-split-crash.html in webkit_layout_tests failing on chromium.webkit/WebKit Android (Nexus4)

Builders failed on: 
- WebKit Android (Nexus4): 
  https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Android%20%28Nexus4%29


 
Cc: -peria@chromium.org
Components: Blink>Fullscreen
Status: Untriaged (was: Available)
It seems this test fails with a CHECK failure in 

[FATAL:layer_tree_host.cc(1132)] Check failed: !has_pushed_local_surface_id_from_parent_ || new_local_surface_id_request_ || !local_surface_id_from_parent_.is_valid().

Culprit CL should be in between 589451 and 590262, and it is difficult to detect it. :(

Layout team; Could you triage this?
Cc: layout-dev@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94ed91b1f58dc886da7ec97ad9cc9ca372d33b13

commit 94ed91b1f58dc886da7ec97ad9cc9ca372d33b13
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Thu Sep 13 04:06:20 2018

LayoutTest: Annotate a layouttest failure on Android

TBR=layout-dev@chromium.org

Bug:  883591 
Change-Id: Ic393ab86f7da12b373dafcb6a1c685e0086d9c0f
Reviewed-on: https://chromium-review.googlesource.com/1223346
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590920}
[modify] https://crrev.com/94ed91b1f58dc886da7ec97ad9cc9ca372d33b13/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/291197fb76e9525e4761c824bdca5fdfa8348e16

commit 291197fb76e9525e4761c824bdca5fdfa8348e16
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Thu Sep 13 09:21:56 2018

Sheriff: Update annotation to be Crash

fullscreen/full-screen-inline-split-crash.html is still
judged to fail. It needs to be labeled as Crash?

This is a follow-up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1223346

TBR=layout-dev@chromium.org

Bug:  883591 
Change-Id: If3036962f84dd2c5027046e44fbe2cc0956123ea
Reviewed-on: https://chromium-review.googlesource.com/1223950
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590958}
[modify] https://crrev.com/291197fb76e9525e4761c824bdca5fdfa8348e16/third_party/WebKit/LayoutTests/TestExpectations

Cc: falken@chromium.org amalova@chromium.org
 Issue 882897  has been merged into this issue.
Labels: -Sheriff-Chromium OS-Android
New test expectation seems to work, and the crashes do not cause builds to fail. Removing from sheriff queue.
Components: -Blink>Fullscreen Internals>Compositing UI>Browser>FullScreen
Crashes in ./cc/trees/layer_tree_host.cc
Owner: fsam...@chromium.org
Status: Assigned (was: Untriaged)
fsamuel: can you find somebody to look at this?
Cc: fsam...@chromium.org
Owner: jonr...@chromium.org
+jonross@
Cc: -layout-dev@chromium.org
Cc: kylec...@chromium.org
+kylechar FYI for OOP-D on Android
Status: Started (was: Assigned)
The CHECK listed in #2 was realized to only be valid on Mac. It has since been restricted to only there.

I plan to remove the crash expectation from this test so that new crashes in the future are logged appropriately.

https://chromium-review.googlesource.com/c/chromium/src/+/1364211/
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b270bbd6b31a08acc546d943f7d615ae58a36943

commit b270bbd6b31a08acc546d943f7d615ae58a36943
Author: jonross <jonross@chromium.org>
Date: Thu Dec 06 17:26:27 2018

Remove Crash Expectation for fullscreen/full-screen-inline-split-crash.html

fullscreen/full-screen-inline-split-crash.html was crashing on Android, do to a
check which is only valid on Mac. This Check has since been restricted to Mac
only.

We no longer expect this to crash. And new crashes should be logged as they
would be different bugs. The most recent run on flaky dashboard shows a pass,
though there is only one recent run found.

I'm removing the crash expectation.

TEST=fullscreen/full-screen-inline-split-crash.html

Bug:  883591 
Change-Id: I3863ac01cba653af98ac4bdb95d326d170ac70d1
Reviewed-on: https://chromium-review.googlesource.com/c/1364211
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614399}
[modify] https://crrev.com/b270bbd6b31a08acc546d943f7d615ae58a36943/third_party/blink/web_tests/TestExpectations

Status: Fixed (was: Started)

Sign in to add a comment