New issue
Advanced search Search tips

Issue 883589 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Improve FileManagerUITests

Project Member Reported by joelhockey@chromium.org, Sep 13

Issue description

Improve FileManagerUITests to generate as much boilerplate as possible.

E.g. generate strings rather than duplicating.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb4d6ee5a4b1c3f4fb3f90b3195fb659e104996b

commit bb4d6ee5a4b1c3f4fb3f90b3195fb659e104996b
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Sep 13 02:20:18 2018

CrOS FilesApp: use file_manager_strings.grdp for test strings.js

Parse file_manager_strings.grdp and chromeos_strings.grdp to
get resource bundle messages.

Parse private_api_strings.cc to match loadTimeData name to
resource bundle message id and populate strings.js for tests.

Bug: 883589
Change-Id: I904625a6f3c2e40cfd9ebafb3b90e2f0dd17c343
Reviewed-on: https://chromium-review.googlesource.com/1215122
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590896}
[modify] https://crrev.com/bb4d6ee5a4b1c3f4fb3f90b3195fb659e104996b/ui/file_manager/file_manager/test/BUILD.gn
[modify] https://crrev.com/bb4d6ee5a4b1c3f4fb3f90b3195fb659e104996b/ui/file_manager/file_manager/test/js/strings.js
[modify] https://crrev.com/bb4d6ee5a4b1c3f4fb3f90b3195fb659e104996b/ui/file_manager/file_manager/test/scripts/create_test_main.py

Sign in to add a comment