Wrong focused window on overview ended because of window drag |
|||||
Issue descriptionChrome Version: 70.0.3538.15 What steps will reproduce the problem? (1) Snap two windows in splitview. (2) Drag window1 into overview. (3) Drag and drop window2 to maximize/full-screened. What is the expected result? Window2 should be maximized/full-screened on the top. What happens instead? window1 becomes the top window instead.
,
Sep 13
,
Sep 19
,
Sep 19
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b1fc9b7853b0f7521da3a1e22393e3d9bde3bb9 commit 0b1fc9b7853b0f7521da3a1e22393e3d9bde3bb9 Author: Min Chen <minch@google.com> Date: Mon Sep 24 22:26:19 2018 Set the dragged window as active window on window drag ended. changes in this cl, - Added overview exit type kWindowDragged for ending overview on window drag. - Set the dragged window as active window on window drag ended, this will make sure the dragged window will not lost its activation on overview ended. - Update the non-dragged windows' bounds at the end of animation. Since we want no animation if overview ends on window drag, including the update bounds animation. Set the animation type to ZERO for all the other windows except the dragged window. Then we can only see the update bounds animation of the dragged window. All the other windows' bounds will be updated at the end of the animation, which can not be seen by users. Bug: 883579 Change-Id: I6a523e6be7caf32757299462cdf6197574768be2 Reviewed-on: https://chromium-review.googlesource.com/1232957 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593715} [modify] https://crrev.com/0b1fc9b7853b0f7521da3a1e22393e3d9bde3bb9/ash/wm/overview/window_selector.h [modify] https://crrev.com/0b1fc9b7853b0f7521da3a1e22393e3d9bde3bb9/ash/wm/overview/window_selector_controller.cc [modify] https://crrev.com/0b1fc9b7853b0f7521da3a1e22393e3d9bde3bb9/ash/wm/splitview/split_view_controller.cc [modify] https://crrev.com/0b1fc9b7853b0f7521da3a1e22393e3d9bde3bb9/ash/wm/splitview/split_view_controller_unittest.cc [modify] https://crrev.com/0b1fc9b7853b0f7521da3a1e22393e3d9bde3bb9/ash/wm/tablet_mode/tablet_mode_window_manager.cc [modify] https://crrev.com/0b1fc9b7853b0f7521da3a1e22393e3d9bde3bb9/ash/wm/tablet_mode/tablet_mode_window_manager.h [modify] https://crrev.com/0b1fc9b7853b0f7521da3a1e22393e3d9bde3bb9/ash/wm/tablet_mode/tablet_mode_window_state.cc [modify] https://crrev.com/0b1fc9b7853b0f7521da3a1e22393e3d9bde3bb9/ash/wm/tablet_mode/tablet_mode_window_state.h [modify] https://crrev.com/0b1fc9b7853b0f7521da3a1e22393e3d9bde3bb9/ash/wm/window_state.cc [modify] https://crrev.com/0b1fc9b7853b0f7521da3a1e22393e3d9bde3bb9/ash/wm/window_state.h
,
Sep 24
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by minch@chromium.org
, Sep 13