New issue
Advanced search Search tips

Issue 883559 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Removed unused and clarify some offline page namespace policy controls

Project Member Reported by carlosk@chromium.org, Sep 12

Issue description

Offline page's FeaturePolicy [1] has a few fields that might have been useful in the past but are not anymore:

* is_supported_by_recent_tabs: not used in production code

* is_removed_on_cache_reset: finally reflects the exact same behavior as the namespace lifetime policy being TEMPORARY and should be consolidated with it.


These fields should be renamed (and potentially have comments reworded) to make their usage clearer:

* disabled_when_prefetch_disabled: this is easily confused with the Offline Prefetch feature when it fact it relates to the user setting for allowing web content to be prefetched for faster page loading.

* should_allow_download: this wording makes it sound like namespaces with this set to false couldn't be downloaded but in fact refers to allowing file downloads to proceed in case these pages are saved in the background.


[1] https://cs.chromium.org/chromium/src/components/offline_pages/core/offline_page_client_policy.h?q=%22struct+FeaturePolicy%22
 
Labels: Hotlist-Fixit
Looks like a fixit item. 
Owner: carlosk@chromium.org
Status: Assigned (was: Untriaged)

Sign in to add a comment