Tast UI tests fail if run before cryptohomed is ready on newly-booted system |
||
Issue descriptionJames sent this: ---- I started an amd64-generic VM image and immediately did this: $ tast -verbose run localhost:9222 ui.ChromeLogin It paused for a while on: 2018/09/12 16:14:02 Connecting to localhost:9222 But went ahead and ran the test. The test failed: 2018/09/12 16:14:22 ui.SingleProcessMashLogin [ FAIL ] Chrome login failed: exit status 1 (Remove call failed: The name org.chromium.Cryptohome was not provided by any .service files.) Subsequent test runs pass. ---- chrome.New should probably use dbusutil.WaitForService early on to wait for session_manager and cryptohomed to take ownership of their D-Bus service names.
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/68e70e80406a690c538ab75fb21c0c06b617273c commit 68e70e80406a690c538ab75fb21c0c06b617273c Author: Daniel Erat <derat@chromium.org> Date: Fri Sep 14 19:08:41 2018 tast-tests: Make chrome.New wait for cryptohomed. Make the chrome.New function wait for cryptohomed to acquire ownership of its D-Bus service name before running the cryptohome command. This prevents a failure if a test runs on a newly-rebooted system before cryptohomed is ready. BUG= chromium:883554 TEST=manual: added a "sleep 20" at the end of pre-start in /etc/init/cryptohomed.conf, rebooted and ran test, and verified that we wait for cryptohomed instead of failing immediately with "Remove call failed: The name org.chromium.Cryptohome was not provided by any .service files." Change-Id: I238141f2e64ef0e6d3830a297fb90c072b0a669a Reviewed-on: https://chromium-review.googlesource.com/1223034 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> [modify] https://crrev.com/68e70e80406a690c538ab75fb21c0c06b617273c/src/chromiumos/tast/local/dbusutil/constants.go [modify] https://crrev.com/68e70e80406a690c538ab75fb21c0c06b617273c/src/chromiumos/tast/local/chrome/chrome.go
,
Sep 14
|
||
►
Sign in to add a comment |
||
Comment 1 by derat@chromium.org
, Sep 13