New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 883544 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 805766
Owner: ----
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 875871
issue 880156



Sign in to add a comment

Parametrized flag no working on ChromeOS

Project Member Reported by ftirelo@chromium.org, Sep 12

Issue description

Chrome Version: M70+
OS: ChromeOS

There seems to be an issue with parametrized flags on ChromeOS. The steps shown below work well on all platforms, but they don't have the right effect on ChromeOS. More details below.

This issue is blocking a11y review of crbug.com/880156 and test review for crbug.com/875871, since testers can't enable the feature on ChromeOS.

What steps will reproduce the problem?
(1) Navigate to chrome://flags/#autofill-preview-style
(2) Select "Enabled (Black on GoogleBlue050)"
(3) Restart the computer
(4) Ensure there is at least one address in chrome://settings/autofill
(5) Navigate to https://dump-truck.appspot.com/usecase-address_and_cc_on_same_page/address_and_cc.html
(6) Click on the "name" field
(7) Hover on the first suggestion.

What is the expected result?

The background color in the field should be a light blue.

What happens instead?

The background color in the field is yellow.

More details:

The flag is defined here: https://chromium.googlesource.com/chromium/src/+/781f4689252249d62fabf0e6fd5867c91128ad72/chrome/browser/about_flags.cc#3951

It enables this feature: https://chromium.googlesource.com/chromium/src/+/781f4689252249d62fabf0e6fd5867c91128ad72/third_party/blink/common/features.cc#12

The code it modifies is this: https://chromium.googlesource.com/chromium/src/+/90d11af7de1d07f516319cece4bf689adc9dca57/third_party/blink/renderer/core/layout/layout_theme.cc#79

I ran it on my local checkout and if I enabled the feature with the params in the command line, I get the expected result. Because of that, I think there is something related to flags handling.

This is the command line that I used:

./chrome --login-manager --enable-features="AutofillPreviewStyleExperiment<AutofillPreviewStyle" --force-fieldtrials="AutofillPreviewStyle/Enabled_GB050" --force-fieldtrial-params="AutofillPreviewStyle.Enabled_GB050:bg_color/#E8F0FE/color/#000000"

 
Description: Show this description
Labels: Target-70 FoundIn-71 FoundIn-70
Mergedinto: 805766
Status: Duplicate (was: Untriaged)
Cc: ftirelo@chromium.org
Is there any way of circumventing this bug? In our case, it's blocking a11y and test reviews for a feature we want to launch in m70 on Chrome OS. For example, is it possible to pass those params via command line flags or forcing an experiment group of an existing field trial?

Sign in to add a comment