New issue
Advanced search Search tips

Issue 883530 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Hide subtitle on network screen in demo mode

Project Member Reported by agawronska@chromium.org, Sep 12

Issue description

The text is not suitable fro demo mode setup.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba27acad1ceed58f7961abd4816b94c014c7f9c6

commit ba27acad1ceed58f7961abd4816b94c014c7f9c6
Author: Aga Wronska <agawronska@chromium.org>
Date: Thu Sep 13 23:06:14 2018

Hide subtitle on network screen in demo mode setup flow.

The subtitle text is not suitable for demo mode setup as there
is no data restoration performed in demo mode.

Bug:  883530 
Test: Manually verified network screen in OOBE and in demo mode setup.
Change-Id: I3e70b4a963f336e59547b64b7a710c99a57ce0f6
Reviewed-on: https://chromium-review.googlesource.com/1222448
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591194}
[modify] https://crrev.com/ba27acad1ceed58f7961abd4816b94c014c7f9c6/chrome/browser/resources/chromeos/login/oobe_network.html

Labels: Merge-Request-70
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 14

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
This very tiny and safe change to be merged.
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 24

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b25f6990e9371b5db4e2b719e0cb14c98f9878ab

commit b25f6990e9371b5db4e2b719e0cb14c98f9878ab
Author: Aga Wronska <agawronska@chromium.org>
Date: Mon Sep 24 21:34:03 2018

Hide subtitle on network screen in demo mode setup flow.

The subtitle text is not suitable for demo mode setup as there
is no data restoration performed in demo mode.

Bug:  883530 
Test: Manually verified network screen in OOBE and in demo mode setup.
Change-Id: I3e70b4a963f336e59547b64b7a710c99a57ce0f6
Reviewed-on: https://chromium-review.googlesource.com/1222448
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591194}(cherry picked from commit ba27acad1ceed58f7961abd4816b94c014c7f9c6)
Reviewed-on: https://chromium-review.googlesource.com/1241567
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#608}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/b25f6990e9371b5db4e2b719e0cb14c98f9878ab/chrome/browser/resources/chromeos/login/oobe_network.html

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/b25f6990e9371b5db4e2b719e0cb14c98f9878ab

Commit: b25f6990e9371b5db4e2b719e0cb14c98f9878ab
Author: agawronska@chromium.org
Commiter: agawronska@chromium.org
Date: 2018-09-24 21:34:03 +0000 UTC

Hide subtitle on network screen in demo mode setup flow.

The subtitle text is not suitable for demo mode setup as there
is no data restoration performed in demo mode.

Bug:  883530 
Test: Manually verified network screen in OOBE and in demo mode setup.
Change-Id: I3e70b4a963f336e59547b64b7a710c99a57ce0f6
Reviewed-on: https://chromium-review.googlesource.com/1222448
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591194}(cherry picked from commit ba27acad1ceed58f7961abd4816b94c014c7f9c6)
Reviewed-on: https://chromium-review.googlesource.com/1241567
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#608}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}

Sign in to add a comment