Adding a new pixel test to check page tile rendering |
|||
Issue descriptionRecently we saw a web page display issue in chrome where different tiles in the webpage overwrites each other and the page content looks broken - https://bugs.chromium.org/p/chromium/issues/detail?id=879937#c22 This issue only occurs when OOP-R is enabled (is enabled now by default) and gpu rasterisation is neither forced disabled or enabled. This was not caught by the gpu tests as we did not had any test which has multiple tiles getting ratsterised. So adding a new pixel test which basically has a image in the test. This creates multiple tiles which then gets rasterized. The issue is reproducible with this test on the broken chrome version.
,
Sep 13
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ec2dcab1c90f7123f9978b687698dbb3960c3ff commit 8ec2dcab1c90f7123f9978b687698dbb3960c3ff Author: Vikas Soni <vikassoni@chromium.org> Date: Fri Sep 14 19:55:59 2018 Add a new pixel test pixel_BackgroundImage. Add a new pixel test which creates and rasterizes multiple tiles. This test is meant to check if all tiles are drawn correctly without overwriting each other contents. Bug: 883500 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I83190b6f887122aaf76cfd74533650e732391cdf Reviewed-on: https://chromium-review.googlesource.com/1222890 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#591440} [add] https://crrev.com/8ec2dcab1c90f7123f9978b687698dbb3960c3ff/content/test/data/gpu/pixel_background_image.html [add] https://crrev.com/8ec2dcab1c90f7123f9978b687698dbb3960c3ff/content/test/data/gpu/single_face.jpg [modify] https://crrev.com/8ec2dcab1c90f7123f9978b687698dbb3960c3ff/content/test/gpu/gpu_tests/pixel_expectations.py [modify] https://crrev.com/8ec2dcab1c90f7123f9978b687698dbb3960c3ff/content/test/gpu/gpu_tests/pixel_test_pages.py
,
Sep 17
Could you please put up a CL removing the failure expectations for this new test? All of the reference images should have been generated by now. Thanks.
,
Sep 17
Yes sure. will do that now.
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/249c24b1bdbc4ca55ee7176f5638942c76edb2f1 commit 249c24b1bdbc4ca55ee7176f5638942c76edb2f1 Author: Vikas Soni <vikassoni@chromium.org> Date: Tue Sep 18 21:11:47 2018 Unmark Pixel_BackgroundImage test as failing. This is a new test which was marked as failing as it uses a reference image. Unmarking it as fail since reference images are produced by all of the GPU bots. Bug: 883500 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I311f8e4a896de0c409772e18efcaf1ee5c29a04e Reviewed-on: https://chromium-review.googlesource.com/1231934 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#592191} [modify] https://crrev.com/249c24b1bdbc4ca55ee7176f5638942c76edb2f1/content/test/gpu/gpu_tests/pixel_expectations.py
,
Sep 18
Per comment here: https://chromium-review.googlesource.com/c/chromium/src/+/1231934#message-e05378af1fc08fcff99ac0ac2c7d2540b9846027 the new test is failing on the Nexus 5 and 6 bots. Until this is diagnosed and fixed, it should be marked Skip on those two bots.
,
Sep 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11fd44936dca9e806bb8c5a0788ef6e20b794c5f commit 11fd44936dca9e806bb8c5a0788ef6e20b794c5f Author: Yuly Novikov <ynovikov@chromium.org> Date: Wed Sep 19 18:06:28 2018 Suppress Pixel_BackgroundImage on Nexus 5, 6 and 6P TBR=kbr@chromium.org Bug: 883500 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idfe7f4fe14a9ef18a08a511fcf825862f4f44142 No-try: True Reviewed-on: https://chromium-review.googlesource.com/1234315 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592470} [modify] https://crrev.com/11fd44936dca9e806bb8c5a0788ef6e20b794c5f/content/test/gpu/gpu_tests/pixel_expectations.py |
|||
►
Sign in to add a comment |
|||
Comment 1 by kbr@chromium.org
, Sep 13