New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 883490 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug-Regression



Sign in to add a comment

PreciseMemoryInfoEnabled nonfunctional with Chrome 69+

Project Member Reported by pweis@google.com, Sep 12

Issue description

Looks like the PreciseMemoryInfoEnabled flag doesn't do anything anymore with https://chromium.googlesource.com/chromium/src/+/7c7847f69de403f6c798dfccba10812039a60480

-MemoryInfo::MemoryInfo() {
+MemoryInfo::MemoryInfo(Precision precision) {
+  // With the experimental PreciseMemoryInfoEnabled flag on, we will not
+  // bucketize or cache values.
   if (RuntimeEnabledFeatures::PreciseMemoryInfoEnabled())
     GetHeapSize(info_);
-  else
-    HeapSizeCache::ForCurrentThread().GetCachedHeapSize(info_);
+  HeapSizeCache::ForCurrentThread().GetCachedHeapSize(info_, precision);
 }

The "else" branch needs to stay.
 
Components: -Blink
Labels: -Type-Bug -Pri-3 Pri-2 Type-Bug-Regression
Status: Assigned (was: Untriaged)
Labels: Hotlist-Partner-GSuite
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84b54aab66e7ddb02051e37ee133f369ea150602

commit 84b54aab66e7ddb02051e37ee133f369ea150602
Author: Nicolas Pena <npm@chromium.org>
Date: Thu Sep 13 14:40:32 2018

Fix performance.memory under the PreciseMemoryInfoEnabled flag

7c7847f accidentally removed an else statement.
This CL fixes this and adds a test for the desired behavior.

Bug:  883490 
Change-Id: I4761450584d31347825228bd2ee76e13483586f7
Reviewed-on: https://chromium-review.googlesource.com/1222866
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591003}
[modify] https://crrev.com/84b54aab66e7ddb02051e37ee133f369ea150602/third_party/blink/renderer/core/timing/memory_info.cc
[modify] https://crrev.com/84b54aab66e7ddb02051e37ee133f369ea150602/third_party/blink/renderer/core/timing/memory_info_test.cc

Labels: Merge-Request-70
Requesting merge to M70. This is a safe fix because it only affects the behavior under the PreciseMemoryInfo which is off by default, but is important for GSuite testing so it needs to be merged.
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 14

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Can you please mark which OS's this is impacting?
Labels: OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows
Any OS that uses Blink.
Labels: -Merge-Review-70 Merge-Approved-70
Waiting for https://chromium-review.googlesource.com/c/chromium/src/+/1228886 and will merge both since that might fix some testing issues as well.
In addition to the testing issues we have internal reports from GSuites saying that performance.memory is returning 0 values in some cases so https://chromium-review.googlesource.com/c/chromium/src/+/1228886 speculatively fixes that (it's unclear to me what the cause of this issue is)
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/699f67f72a02ea3cb12efb6095bd30bc391d3cd7

commit 699f67f72a02ea3cb12efb6095bd30bc391d3cd7
Author: Nicolas Pena <npm@chromium.org>
Date: Tue Sep 18 16:32:21 2018

Speculative fix for 0-valued performance.memory

This CL ensures that the first call to MaybeUpdate() results in calling
Update() so that MemoryInfo is populated. Technically the monotonic
clock could be initialized to a small value and in this case the first
time this check occurs it could fail, whereas we want it to pass:
"now - last_update_time_ >= delta_allowed"

Bug:  883490 
Change-Id: I7143d453709db38068919cff9585c50e06e789ac
Reviewed-on: https://chromium-review.googlesource.com/1228886
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592071}
[modify] https://crrev.com/699f67f72a02ea3cb12efb6095bd30bc391d3cd7/third_party/blink/renderer/core/timing/memory_info.cc
[modify] https://crrev.com/699f67f72a02ea3cb12efb6095bd30bc391d3cd7/third_party/blink/renderer/core/timing/memory_info_test.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 18

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5875a4294656a0d1114130484b2adc9bb2248884

commit 5875a4294656a0d1114130484b2adc9bb2248884
Author: Nicolas Pena <npm@chromium.org>
Date: Tue Sep 18 16:34:33 2018

Fix performance.memory under the PreciseMemoryInfoEnabled flag

7c7847f accidentally removed an else statement.
This CL fixes this and adds a test for the desired behavior.

Bug:  883490 
Change-Id: I4761450584d31347825228bd2ee76e13483586f7
Reviewed-on: https://chromium-review.googlesource.com/1222866
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591003}(cherry picked from commit 84b54aab66e7ddb02051e37ee133f369ea150602)
Reviewed-on: https://chromium-review.googlesource.com/1231373
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#494}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/5875a4294656a0d1114130484b2adc9bb2248884/third_party/blink/renderer/core/timing/memory_info.cc
[modify] https://crrev.com/5875a4294656a0d1114130484b2adc9bb2248884/third_party/blink/renderer/core/timing/memory_info_test.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f83449034f8ca2fb46066f8ada56ae6acc3d5637

commit f83449034f8ca2fb46066f8ada56ae6acc3d5637
Author: Nicolas Pena <npm@chromium.org>
Date: Tue Sep 18 16:35:47 2018

Speculative fix for 0-valued performance.memory

This CL ensures that the first call to MaybeUpdate() results in calling
Update() so that MemoryInfo is populated. Technically the monotonic
clock could be initialized to a small value and in this case the first
time this check occurs it could fail, whereas we want it to pass:
"now - last_update_time_ >= delta_allowed"

Bug:  883490 
Change-Id: I7143d453709db38068919cff9585c50e06e789ac
Reviewed-on: https://chromium-review.googlesource.com/1228886
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592071}(cherry picked from commit 699f67f72a02ea3cb12efb6095bd30bc391d3cd7)
Reviewed-on: https://chromium-review.googlesource.com/1231294
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#496}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/f83449034f8ca2fb46066f8ada56ae6acc3d5637/third_party/blink/renderer/core/timing/memory_info.cc
[modify] https://crrev.com/f83449034f8ca2fb46066f8ada56ae6acc3d5637/third_party/blink/renderer/core/timing/memory_info_test.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment