New issue
Advanced search Search tips

Issue 883487 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 789779
issue 830882
issue 860247



Sign in to add a comment

Move EQT calculator to components

Project Member Reported by npm@chromium.org, Sep 12

Issue description

This is a tracking bug for moving the QueueingTimeEstimator out of the Blink scheduler and into components/scheduling_metrics. This will allow reporting EQT outside of Blink, for instance browser process.
 
Blocking: 789779 830882
Cc: npm@chromium.org
Owner: tommckee@chromium.org
Status: Started (was: Assigned)
Grabbing this bug b/c I'm working on the refactor a.t.m.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/852a0827af0049357673349a19c4b91458b08efb

commit 852a0827af0049357673349a19c4b91458b08efb
Author: Tom McKee <tommckee@chromium.org>
Date: Mon Oct 29 17:10:12 2018

A small renaming to reduce coupling.

The QueueingTimeEstimator had a flag that was, effectively, a
disabled/enabled flag. Instead of naming it for the external state that
causes updates to the flag, name it for what the flag is used for inside
the QueueingTimeEstimator.

Bug: 883487
Change-Id: I73c7f71ff10fcacaf1e85a3f89f5e1a123b78896
Reviewed-on: https://chromium-review.googlesource.com/c/1296822
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603535}
[modify] https://crrev.com/852a0827af0049357673349a19c4b91458b08efb/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/852a0827af0049357673349a19c4b91458b08efb/third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator.cc
[modify] https://crrev.com/852a0827af0049357673349a19c4b91458b08efb/third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator.h
[modify] https://crrev.com/852a0827af0049357673349a19c4b91458b08efb/third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator_unittest.cc
[modify] https://crrev.com/852a0827af0049357673349a19c4b91458b08efb/third_party/blink/renderer/platform/scheduler/test/test_queueing_time_estimator_client.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e52da1b8552c9a23e332dfc63b5cb480f3c6966f

commit e52da1b8552c9a23e332dfc63b5cb480f3c6966f
Author: Tom McKee <tommckee@chromium.org>
Date: Thu Nov 01 17:15:44 2018

[scheduler] Rename member variable in QueueingTimeEstimator.

Rename step_queueing_times_ to sliding_window_ to better clarity.

Bug: 883487
Change-Id: I778db437b734a8e498efb69eb3aeff20aeb7cc47
Reviewed-on: https://chromium-review.googlesource.com/c/1299548
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604623}
[modify] https://crrev.com/e52da1b8552c9a23e332dfc63b5cb480f3c6966f/third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator.cc
[modify] https://crrev.com/e52da1b8552c9a23e332dfc63b5cb480f3c6966f/third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator.h

Blocking: 860247

Sign in to add a comment