New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 883474 link

Starred by 1 user
Status: Fixed
Owner:
█ jordynass@chromium.org
Last visit > 30 days ago
Closed: Sep 17
Cc:
jessejames@google.com
█ jlklein@chromium.org
shibasheikh@chromium.org
khorimoto@chromium.org
█ jhawkins@chromium.org
hansberry@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-09-24
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

Setup Flow: strings out of sync with SoT doc

Project Member Reported by jordynass@chromium.org, Sep 12 
The source of truth for all strings in MultiDevice Setup Flow and Settings UIs is the 'Recommended string' column in https://docs.google.com/document/d/11iBTQ_NnlJ23G23F7BSCFajBeZzaj8qR9zQdnwoPMAg/edit?usp=sharing

In at least one spot the HEAD version (screen/s4qcOniodzC) disagrees with the SoT doc (screen/swenvB10tfe)

We need to fix that one and verify that all other strings in Setup Flow and Settings UIs match the SoT doc.

Comment 1 by khorimoto@chromium.org, Sep 12

Cc: jhawkins@chromium.org hansberry@chromium.org
Status: Assigned (was: Available)

Comment 2 by khorimoto@chromium.org, Sep 12

NextAction: 2018-09-24
FYI, strings are due by the "feature freeze" date, which is 9/28 for M-71. Adding a NextAction date as a reminder just in case.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47ee9f6fa8e9e6833f6064fd71c13adfd6d34f3a

commit 47ee9f6fa8e9e6833f6064fd71c13adfd6d34f3a
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Sat Sep 15 01:17:07 2018

[CrOS Multidevice] Update Strings in Setup Flow and Settings UIs

Note that I did not update the Instant Tethering subtext but that is a
little more involved in that it may require refactoring
network-summary-item. Once I've fixed that I will sweep through and
double check all strings in both UIs.

Below are screenshots of the changes...

SETUP FLOW
Start setup page string changes: screen/C0fZSBURQai
Start setup page learn more link for messages: screen/LU3KYRHr1sN
Password prompt: screen/ZSsBEsW584o

SETTINGS
Periods deleted from learn more links in top level page:
screen/JwibdRciTcm
screen/NHEYcoOwWiG
screen/4j21Ai5yodW

Bug:  883474 , 870108
Change-Id: Ie6c136925add22969358c1117fa3533bffbff542
Reviewed-on: https://chromium-review.googlesource.com/1226516
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591548}
[modify] https://crrev.com/47ee9f6fa8e9e6833f6064fd71c13adfd6d34f3a/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/47ee9f6fa8e9e6833f6064fd71c13adfd6d34f3a/chrome/app/settings_strings.grdp
[modify] https://crrev.com/47ee9f6fa8e9e6833f6064fd71c13adfd6d34f3a/chrome/browser/resources/chromeos/multidevice_setup/start_setup_page.html
[modify] https://crrev.com/47ee9f6fa8e9e6833f6064fd71c13adfd6d34f3a/chrome/browser/resources/chromeos/multidevice_setup/ui_page_container_behavior.js
[modify] https://crrev.com/47ee9f6fa8e9e6833f6064fd71c13adfd6d34f3a/chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_dialog.cc
[modify] https://crrev.com/47ee9f6fa8e9e6833f6064fd71c13adfd6d34f3a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/47ee9f6fa8e9e6833f6064fd71c13adfd6d34f3a/chrome/common/url_constants.cc
[modify] https://crrev.com/47ee9f6fa8e9e6833f6064fd71c13adfd6d34f3a/chromeos/services/multidevice_setup/public/cpp/url_provider.cc
[modify] https://crrev.com/47ee9f6fa8e9e6833f6064fd71c13adfd6d34f3a/chromeos/services/multidevice_setup/public/cpp/url_provider.h

Comment 4 by khorimoto@chromium.org, Sep 17

Status: Fixed (was: Assigned)

Comment 5 by monor...@bugs.chromium.org, Sep 24 

The NextAction date has arrived: 2018-09-24
►

Sign in to add a comment