Chrome should foreground tabs when they are getting closed |
||||
Issue descriptiongab@ says in https://crbug.com/881812#c8 that we should ideally "foreground" background tabs when on unload/close (otherwise we have a shutdown priority inversion). This doesn't seem to be actually happening in practice - see https://crrev.com/c/1222673 (note that this CL depends on a not-yet-landing refactoring from https://crrev.com/c/1222249 that enables process priority testing on Linux).
,
Sep 12
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbc55f660b075b69a081a7715eeac440ac3025b5 commit bbc55f660b075b69a081a7715eeac440ac3025b5 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Fri Sep 14 16:14:43 2018 Enable ChromeRenderProcessHostBackgroundingTest.MultipleTabs on Linux. While |base::Process::CanBackgroundProcesses()| returns false on Linux, we are still able to verify whether processes are backgrounded by looking at RenderProcessHost::IsProcessBackgrounded(). This verification is not as thorough/end-to-end as what we can do on other platforms, but it is sufficient to enable ChromeRenderProcessHostBackgroundingTest.MultipleTabs test on Linux. Bug: 881812 , 883468 Change-Id: I536ea10a279d7138d632b8846dc2a0d8e507c001 Reviewed-on: https://chromium-review.googlesource.com/1222249 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#591363} [modify] https://crrev.com/bbc55f660b075b69a081a7715eeac440ac3025b5/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
,
Sep 14
Tentatively assigning to gab@ (since he was the one pointing out the desirability of foregrounding in this scenario).
,
Sep 14
I was hoping you would pick this up too :), I don't think I'll be able to find time for this shortly. |
||||
►
Sign in to add a comment |
||||
Comment 1 by lukasza@chromium.org
, Sep 12