New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 883456 link

Starred by 3 users
Status: Verified
Owner:
frechette@chromium.org
Closed: Dec 4
Cc:
█ zkoch@chromium.org
yyushkina@chromium.org
█ cyriln@google.com
benmason@chromium.org
█ nickrad@chromium.org
anthonyvd@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature



Sign in to add a comment

Add a manual translation options to Chrome for Android.

Project Member Reported by frechette@chromium.org, Sep 12 
Feature description:
In overflow menu, have a entry for manual translation of the current page.

Potentially show entry intelligently (e.g. based on current page language).

Eng owner: frechette@chromium.org
Product owner: yyushkina@chromium.org

Design doc: 

Are you planning on experimenting before launch?
Any new strings?
Any implications for Google webservices (i.e. sync, translate)?
Binary size?
Do the existing perf tests exercise all aspects of your new feature(s)?

Comment 1 by frechette@chromium.org, Sep 12

Status: Started (was: Assigned)

Comment 2 by frechette@chromium.org, Sep 12

Description: Show this description

Comment 3 by yyushkina@chromium.org, Sep 12 

PS: we should show it always instead of based on the page language since 1)Sometimes we misdetect the language of the page and 2)We want to give users the option to trigger translation even if the page is in the same language as the UI.

Comment 4 Deleted

Comment 6 by yyushkina@chromium.org, Oct 1

Cc: nickrad@chromium.org zkoch@chromium.org groby@chromium.org cyriln@google.com
 Issue 792720  has been merged into this issue.

Comment 7 by yyushkina@chromium.org, Oct 9

Labels: Target-71
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8

commit 4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Thu Oct 11 22:09:18 2018

[Translate Manual Trigger] Add a manual translation button to Chrome android app menu.

- Add Chrome translation button.
- Hide button behind feature.
- Add bridge infrastructure to (eventually) trigger translation (through TranslateManager) from Clank.

SCREENSHOT: https://screenshot.googleplex.com/UOxkufab1T5.png

Change-Id: I526405e9c57266af3807b8e7e8666845e9a0a118
Bug:  883456 
Reviewed-on: https://chromium-review.googlesource.com/c/1249822
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598976}
[modify] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/chrome/android/java/res/menu/main_menu.xml
[modify] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[add] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/chrome/android/java/src/org/chromium/chrome/browser/translate/TranslateBridge.java
[modify] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/chrome/android/java/strings/android_chrome_strings.grd
[add] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/chrome/android/java/strings/android_chrome_strings_grd/IDS_MENU_TRANSLATE.png.sha1
[modify] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/chrome/android/java_sources.gni
[modify] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/chrome/browser/BUILD.gn
[modify] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/chrome/browser/about_flags.cc
[modify] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/chrome/browser/flag_descriptions.h
[add] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/chrome/browser/translate/android/translate_bridge.cc
[modify] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/components/translate/core/browser/translate_prefs.cc
[modify] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/components/translate/core/browser/translate_prefs.h
[modify] https://crrev.com/4623e1b70503b3e86a2af07cbffdcb8aeac7f1d8/tools/metrics/histograms/enums.xml
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/703b0c073a87b387efb0e7f095a6cbf1a2f56adf

commit 703b0c073a87b387efb0e7f095a6cbf1a2f56adf
Author: Alexandre Frechette <frechette@chromium.org>
Date: Tue Oct 23 16:02:28 2018

[Translate Manual Trigger] Added logic to check for manual translation availability and to (manually) initiate a translation.

Change-Id: I2fdd9832a72fa1700190d4f7ee93365f29579b32
Bug:  883456 
Reviewed-on: https://chromium-review.googlesource.com/c/1281086
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601970}
[modify] https://crrev.com/703b0c073a87b387efb0e7f095a6cbf1a2f56adf/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/703b0c073a87b387efb0e7f095a6cbf1a2f56adf/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
[modify] https://crrev.com/703b0c073a87b387efb0e7f095a6cbf1a2f56adf/chrome/android/java/src/org/chromium/chrome/browser/translate/TranslateBridge.java
[modify] https://crrev.com/703b0c073a87b387efb0e7f095a6cbf1a2f56adf/chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateCompactInfoBarTest.java
[modify] https://crrev.com/703b0c073a87b387efb0e7f095a6cbf1a2f56adf/chrome/browser/translate/android/translate_bridge.cc
[modify] https://crrev.com/703b0c073a87b387efb0e7f095a6cbf1a2f56adf/chrome/test/android/javatests/src/org/chromium/chrome/test/util/TranslateUtil.java
[modify] https://crrev.com/703b0c073a87b387efb0e7f095a6cbf1a2f56adf/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/703b0c073a87b387efb0e7f095a6cbf1a2f56adf/components/translate/core/browser/translate_manager.h
[modify] https://crrev.com/703b0c073a87b387efb0e7f095a6cbf1a2f56adf/components/translate/core/browser/translate_manager_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41f25f6609915ad5eafc1532a81d2f7368ea38fc

commit 41f25f6609915ad5eafc1532a81d2f7368ea38fc
Author: Alexandre Frechette <frechette@chromium.org>
Date: Wed Oct 24 20:03:33 2018

[Translate Manual Trigger] Made `prepareTranslateMenuItem` inline.

Bug:  883456 
Change-Id: I990f680aeb7cb7c18571abc63c09573bcc6f3b1c
Reviewed-on: https://chromium-review.googlesource.com/c/1297486
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602414}
[modify] https://crrev.com/41f25f6609915ad5eafc1532a81d2f7368ea38fc/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Comment 12 by yyushkina@chromium.org, Oct 25

Labels: -Pri-2 Pri-1

Comment 13 by yyushkina@chromium.org, Oct 25

Labels: Merge-Request-71
Requesting merge to M71 for c10 and c11, changes are verified in Canary and guarded by flag.
Project Member

Comment 14 by sheriffbot@chromium.org, Oct 25

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: There is .grd file changes and we are only 39 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 15 by yyushkina@chromium.org, Oct 25

Cc: benmason@chromium.org
No strings were affected by this change.

Comment 16 by frechette@chromium.org, Oct 25 

In fact, c9, c10 and c11 would need to be merged to M71. The .grd changes come from c8, which is already in the cut.

Comment 17 by benmason@chromium.org, Oct 25

Labels: -Hotlist-Merge-Review -Merge-Review-71 Merge-Approved-71
Approved for merge to 71.
Project Member

Comment 18 by cr-audit...@appspot.gserviceaccount.com, Oct 25

Labels: -Merge-Approved-71 Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/b9c41d606b1cf060b59d22cd2a0b3aa3ea96f15f

Commit: b9c41d606b1cf060b59d22cd2a0b3aa3ea96f15f
Author: frechette@chromium.org
Commiter: anthonyvd@chromium.org
Date: 2018-10-25 19:12:45 +0000 UTC

[Translate Manual Trigger] Added logic to check for manual translation availability and to (manually) initiate a translation.

Change-Id: I2fdd9832a72fa1700190d4f7ee93365f29579b32
Bug:  883456 
Reviewed-on: https://chromium-review.googlesource.com/c/1281086
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601970}(cherry picked from commit 703b0c073a87b387efb0e7f095a6cbf1a2f56adf)
Reviewed-on: https://chromium-review.googlesource.com/c/1299661
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#331}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 25

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9c41d606b1cf060b59d22cd2a0b3aa3ea96f15f

commit b9c41d606b1cf060b59d22cd2a0b3aa3ea96f15f
Author: Alexandre Frechette <frechette@chromium.org>
Date: Thu Oct 25 19:12:45 2018

[Translate Manual Trigger] Added logic to check for manual translation availability and to (manually) initiate a translation.

Change-Id: I2fdd9832a72fa1700190d4f7ee93365f29579b32
Bug:  883456 
Reviewed-on: https://chromium-review.googlesource.com/c/1281086
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601970}(cherry picked from commit 703b0c073a87b387efb0e7f095a6cbf1a2f56adf)
Reviewed-on: https://chromium-review.googlesource.com/c/1299661
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#331}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/b9c41d606b1cf060b59d22cd2a0b3aa3ea96f15f/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/b9c41d606b1cf060b59d22cd2a0b3aa3ea96f15f/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
[modify] https://crrev.com/b9c41d606b1cf060b59d22cd2a0b3aa3ea96f15f/chrome/android/java/src/org/chromium/chrome/browser/translate/TranslateBridge.java
[modify] https://crrev.com/b9c41d606b1cf060b59d22cd2a0b3aa3ea96f15f/chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateCompactInfoBarTest.java
[modify] https://crrev.com/b9c41d606b1cf060b59d22cd2a0b3aa3ea96f15f/chrome/browser/translate/android/translate_bridge.cc
[modify] https://crrev.com/b9c41d606b1cf060b59d22cd2a0b3aa3ea96f15f/chrome/test/android/javatests/src/org/chromium/chrome/test/util/TranslateUtil.java
[modify] https://crrev.com/b9c41d606b1cf060b59d22cd2a0b3aa3ea96f15f/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/b9c41d606b1cf060b59d22cd2a0b3aa3ea96f15f/components/translate/core/browser/translate_manager.h
[modify] https://crrev.com/b9c41d606b1cf060b59d22cd2a0b3aa3ea96f15f/components/translate/core/browser/translate_manager_unittest.cc
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c637b48d3cada307861ab5be1c854c5e6b9de8f

commit 9c637b48d3cada307861ab5be1c854c5e6b9de8f
Author: Alexandre Frechette <frechette@chromium.org>
Date: Thu Oct 25 19:14:00 2018

[Translate Manual Trigger] Add metrics tracking interaction with manual translate.

Bug:  883456 
Change-Id: I48aab1bb09fe5527cc6ad07a9c3ccadc87224055
Reviewed-on: https://chromium-review.googlesource.com/c/1291784
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602145}(cherry picked from commit 620aa393765f737ff0dae2bd7d8bf8f9b907b201)
Reviewed-on: https://chromium-review.googlesource.com/c/1299662
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#332}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/9c637b48d3cada307861ab5be1c854c5e6b9de8f/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/9c637b48d3cada307861ab5be1c854c5e6b9de8f/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/9c637b48d3cada307861ab5be1c854c5e6b9de8f/tools/metrics/actions/actions.xml
[modify] https://crrev.com/9c637b48d3cada307861ab5be1c854c5e6b9de8f/tools/metrics/histograms/histograms.xml
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49a15f3dbd31ccfc3ebbdfedc5cd50faa6dc3550

commit 49a15f3dbd31ccfc3ebbdfedc5cd50faa6dc3550
Author: Alexandre Frechette <frechette@chromium.org>
Date: Thu Oct 25 19:14:33 2018

[Translate Manual Trigger] Made `prepareTranslateMenuItem` inline.

Bug:  883456 
Change-Id: I990f680aeb7cb7c18571abc63c09573bcc6f3b1c
Reviewed-on: https://chromium-review.googlesource.com/c/1297486
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602414}(cherry picked from commit 41f25f6609915ad5eafc1532a81d2f7368ea38fc)
Reviewed-on: https://chromium-review.googlesource.com/c/1299663
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#333}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/49a15f3dbd31ccfc3ebbdfedc5cd50faa6dc3550/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
Project Member

Comment 22 by cr-audit...@appspot.gserviceaccount.com, Oct 25 

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/49a15f3dbd31ccfc3ebbdfedc5cd50faa6dc3550

Commit: 49a15f3dbd31ccfc3ebbdfedc5cd50faa6dc3550
Author: frechette@chromium.org
Commiter: anthonyvd@chromium.org
Date: 2018-10-25 19:14:33 +0000 UTC

[Translate Manual Trigger] Made `prepareTranslateMenuItem` inline.

Bug:  883456 
Change-Id: I990f680aeb7cb7c18571abc63c09573bcc6f3b1c
Reviewed-on: https://chromium-review.googlesource.com/c/1297486
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602414}(cherry picked from commit 41f25f6609915ad5eafc1532a81d2f7368ea38fc)
Reviewed-on: https://chromium-review.googlesource.com/c/1299663
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#333}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 23 by cr-audit...@appspot.gserviceaccount.com, Oct 25 

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/9c637b48d3cada307861ab5be1c854c5e6b9de8f

Commit: 9c637b48d3cada307861ab5be1c854c5e6b9de8f
Author: frechette@chromium.org
Commiter: anthonyvd@chromium.org
Date: 2018-10-25 19:14:00 +0000 UTC

[Translate Manual Trigger] Add metrics tracking interaction with manual translate.

Bug:  883456 
Change-Id: I48aab1bb09fe5527cc6ad07a9c3ccadc87224055
Reviewed-on: https://chromium-review.googlesource.com/c/1291784
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602145}(cherry picked from commit 620aa393765f737ff0dae2bd7d8bf8f9b907b201)
Reviewed-on: https://chromium-review.googlesource.com/c/1299662
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#332}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Comment 24 by groby@chromium.org, Oct 25

Cc: -groby@chromium.org
Project Member

Comment 25 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d554e8b211c50872b2073de832597ed790b3ffae

commit d554e8b211c50872b2073de832597ed790b3ffae
Author: Alexandre Frechette <frechette@chromium.org>
Date: Thu Nov 01 18:23:50 2018

[Translate Manual Trigger] Relocate the translate menu button.

To increase visibility of the translate button on smaller screen device, we put it above the share
button. See discussion in PRD: go/chrome-translate-manual-trigger.

SCREENSHOT: https://screenshot.googleplex.com/NWuZVLCYSPn.png

Bug:  883456 
Change-Id: I7d334995e9cf7d15c312d23027c99ea52937d27e
Reviewed-on: https://chromium-review.googlesource.com/c/1287093
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604644}
[modify] https://crrev.com/d554e8b211c50872b2073de832597ed790b3ffae/chrome/android/java/res/menu/main_menu.xml
Project Member

Comment 26 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2a9995fbebdb95456387ad90e7fa3954edb923d

commit a2a9995fbebdb95456387ad90e7fa3954edb923d
Author: Alexandre Frechette <frechette@chromium.org>
Date: Thu Nov 01 18:40:39 2018

[Translate Manual Trigger] Relocate the translate menu button.

To increase visibility of the translate button on smaller screen device, we put it above the share
button. See discussion in PRD: go/chrome-translate-manual-trigger.

SCREENSHOT: https://screenshot.googleplex.com/NWuZVLCYSPn.png

Bug:  883456 
Change-Id: I7d334995e9cf7d15c312d23027c99ea52937d27e
Reviewed-on: https://chromium-review.googlesource.com/c/1287093
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#604644}(cherry picked from commit d554e8b211c50872b2073de832597ed790b3ffae)
Reviewed-on: https://chromium-review.googlesource.com/c/1312572
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#453}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/a2a9995fbebdb95456387ad90e7fa3954edb923d/chrome/android/java/res/menu/main_menu.xml
Project Member

Comment 27 by cr-audit...@appspot.gserviceaccount.com, Nov 1 

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/a2a9995fbebdb95456387ad90e7fa3954edb923d

Commit: a2a9995fbebdb95456387ad90e7fa3954edb923d
Author: frechette@chromium.org
Commiter: anthonyvd@chromium.org
Date: 2018-11-01 18:40:39 +0000 UTC

[Translate Manual Trigger] Relocate the translate menu button.

To increase visibility of the translate button on smaller screen device, we put it above the share
button. See discussion in PRD: go/chrome-translate-manual-trigger.

SCREENSHOT: https://screenshot.googleplex.com/NWuZVLCYSPn.png

Bug:  883456 
Change-Id: I7d334995e9cf7d15c312d23027c99ea52937d27e
Reviewed-on: https://chromium-review.googlesource.com/c/1287093
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#604644}(cherry picked from commit d554e8b211c50872b2073de832597ed790b3ffae)
Reviewed-on: https://chromium-review.googlesource.com/c/1312572
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#453}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 28 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d990748160be9a0e551f73febac3f02eb9a124d

commit 3d990748160be9a0e551f73febac3f02eb9a124d
Author: Alexandre Frechette <frechette@chromium.org>
Date: Fri Nov 02 20:31:21 2018

[Translate Manual Trigger] Adding IPH for translate menu button.

The PRD in the bug explains how we wanted it to look, and when we wanted it to appear.

SCREENSHOT: https://screenshot.googleplex.com/WEy35zvdt6O.png
SCREENCAST: https://drive.google.com/open?id=1SURR2EP4UN35lPZQYUw2iceivWGnDO2y

Bug:883456

Change-Id: Ib94be66d45cd809f995d01c6429e563371e550f1
Reviewed-on: https://chromium-review.googlesource.com/c/1259806
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605038}
[modify] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/chrome/android/java/src/org/chromium/chrome/browser/translate/TranslateBridge.java
[modify] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/chrome/android/java/strings/android_chrome_strings.grd
[add] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/chrome/android/java/strings/android_chrome_strings_grd/IDS_IPH_TRANSLATE_MANUAL_BUTTON_TEXT.png.sha1
[modify] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/chrome/browser/translate/android/translate_bridge.cc
[modify] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java
[modify] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java
[modify] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/components/feature_engagement/public/feature_constants.cc
[modify] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/components/feature_engagement/public/feature_constants.h
[modify] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/components/feature_engagement/public/feature_list.cc
[modify] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/components/feature_engagement/public/feature_list.h
[modify] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/tools/metrics/actions/actions.xml
[modify] https://crrev.com/3d990748160be9a0e551f73febac3f02eb9a124d/tools/metrics/histograms/histograms.xml
Project Member

Comment 29 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbcefffa7f3a3e7126642a2a24cda4994c250b1a

commit bbcefffa7f3a3e7126642a2a24cda4994c250b1a
Author: Alexandre Frechette <frechette@chromium.org>
Date: Tue Nov 06 18:44:58 2018

[Translate Manual Trigger] Fixing IPH triggering.

Fixing logic bug in IPH triggering logic. Adding a variation for "force trigger on english" experiment as a flag to automatically trigger it.

Bug:  883456 
Change-Id: Ice024580601fdfe5debb862bb7cfeff956b04dbc
Reviewed-on: https://chromium-review.googlesource.com/c/1318631
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605757}
[modify] https://crrev.com/bbcefffa7f3a3e7126642a2a24cda4994c250b1a/chrome/browser/about_flags.cc
[modify] https://crrev.com/bbcefffa7f3a3e7126642a2a24cda4994c250b1a/chrome/browser/translate/android/translate_bridge.cc
[modify] https://crrev.com/bbcefffa7f3a3e7126642a2a24cda4994c250b1a/components/language/core/common/language_experiments.cc
[modify] https://crrev.com/bbcefffa7f3a3e7126642a2a24cda4994c250b1a/components/language/core/common/language_experiments.h

Comment 30 by frechette@chromium.org, Dec 4

Status: Verified (was: Started)
►

Sign in to add a comment