New issue
Advanced search Search tips

Issue 883453 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 862161
Owner: ----
Closed: Sep 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Prevent virtual/stable/webexposed tests from being disabled via TestExpecations

Project Member Reported by rbyers@chromium.org, Sep 12

Issue description

virtual/stable/webexposed tests are used to help validate that the blink launch process is being followed when new APIs are shipped.  As such blink API owner review is required for changes to them: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/virtual/stable/webexposed/OWNERS

However, there have been a couple cases where people have disabled some or all of these tests completely without (presumably) understanding the implications of doing so, and it's taken us weeks to notice that we no longer had protection against accidental API additions/removals (which have actually occurred in the past).

Perhaps we should add some infrastructure to the test runner to fail (or ignore) attempts to disable tests in virtual/stable/webexposed? Obviously we can't (and shouldn't try to) prevent someone determined to bypass our process (TBR is always an option). This is just to try to reduce the risk of accidents which I've now seen happen at least twice.
 
Mergedinto: 862161
Status: Duplicate (was: Unconfirmed)
Yes, definitely need to prevent these tests from being disabled.

Previously logged in bug 862161.

Sign in to add a comment