This merge request pertains to this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=853185 The CLs we need to merge are: https://chromiumdash.appspot.com/commit/f5420d17fdf394d32cae5d391613e7dbcc6acd3d https://chromiumdash.appspot.com/commit/6498431e2138bed86d4f8c5ba5bba60e10498ef2 Theses are in canary 71.0.3549.0 These CLs are noops unless the vaapi vp8 encoder experiment is enabled. It is currently default off due to issues observed with screen content. With this code we are able to blacklist this particular implementation for screen content and will be able to start experimenting.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd32f02a65c700f0df259c3d63d4d6ca884ad555 commit bd32f02a65c700f0df259c3d63d4d6ca884ad555 Author: Erik Språng <sprang@chromium.org> Date: Thu Sep 13 16:27:29 2018 Add support for configuring content type for VideoEncodeAccelerators Bug: chromium:853185, chromium:883436 Change-Id: I5e0a76e83318d7761d9d010b0083abc048f563e4 Reviewed-on: https://chromium-review.googlesource.com/1183665 Commit-Queue: Erik Språng <sprang@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588358}(cherry picked from commit f5420d17fdf394d32cae5d391613e7dbcc6acd3d) Reviewed-on: https://chromium-review.googlesource.com/1224110 Cr-Commit-Position: refs/branch-heads/3538@{#370} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/bd32f02a65c700f0df259c3d63d4d6ca884ad555/media/mojo/clients/mojo_video_encode_accelerator_unittest.cc [modify] https://crrev.com/bd32f02a65c700f0df259c3d63d4d6ca884ad555/media/mojo/interfaces/video_encode_accelerator.mojom [modify] https://crrev.com/bd32f02a65c700f0df259c3d63d4d6ca884ad555/media/mojo/interfaces/video_encode_accelerator_mojom_traits.cc [modify] https://crrev.com/bd32f02a65c700f0df259c3d63d4d6ca884ad555/media/mojo/interfaces/video_encode_accelerator_mojom_traits.h [modify] https://crrev.com/bd32f02a65c700f0df259c3d63d4d6ca884ad555/media/video/video_encode_accelerator.cc [modify] https://crrev.com/bd32f02a65c700f0df259c3d63d4d6ca884ad555/media/video/video_encode_accelerator.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55ef3690e6f8306f4d26f2a5506ded25e1a6b4c3 commit 55ef3690e6f8306f4d26f2a5506ded25e1a6b4c3 Author: Erik Språng <sprang@chromium.org> Date: Fri Sep 14 12:34:40 2018 Disable vp8 screen content for vaapi Bug: chromium:853185, chromium:883436 , b:111781384 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7bc0dc619503bbb5d0b1ed5420187f0338e160a4 Reviewed-on: https://chromium-review.googlesource.com/1201859 Commit-Queue: Erik Språng <sprang@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Reviewed-by: Pawel Osciak <posciak@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#589874}(cherry picked from commit 6498431e2138bed86d4f8c5ba5bba60e10498ef2) Reviewed-on: https://chromium-review.googlesource.com/1224552 Cr-Commit-Position: refs/branch-heads/3538@{#402} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/55ef3690e6f8306f4d26f2a5506ded25e1a6b4c3/content/renderer/media/webrtc/rtc_video_encoder.cc [modify] https://crrev.com/55ef3690e6f8306f4d26f2a5506ded25e1a6b4c3/media/gpu/vaapi/vaapi_video_encode_accelerator.cc
Comment 1 by geo...@google.com
, Sep 12