Google Finance favicon clobbers Google favicon |
||||
Issue descriptionKevin Bailey discovered this very interesting bug. Repro steps: 1. Go to https://www.google.com/search?q=msft&tbm=fin 2. Wait for the page to load and the finance favicon to show on the tab. 3. Open a new tab page and start typing a search query. 4. The Google search icon may now show the Google Finance icon. I think the root cause is that the URL looks pretty much identical to a plain Google search, and is matching the default search provider. Once the favicon loads on the Finance page, Chrome thinks: "Looks like Google got a new favicon with a graph. Let me update my default search provider metadata." In fact... that above page also triggers Query in Omnibox, since it looks like a Google Search Query. One possibility: Could we / should we update our TemplateURL system to exclude or distinguish these Google scoped searches?
,
Sep 12
All of the other Google search modes offer up the same G icon, so I think we should ask Search if they'd be willing to do the same thing for Finance.
,
Sep 12
pkasting: But I'd also be interested to know if you have any thoughts on tommycli's question ("Could we / should we update our TemplateURL system to exclude or distinguish these Google scoped searches?"). If it was possible to do this without a big effort, it would help in other ways such as "query in omnibox".
,
Sep 12
I don't see an easy way to handle this.
,
Sep 24
I'm hitting this too. Looks like these were added in b/112206374
,
Sep 24
In Issue 88243 , we decided to update the favicon metadata of the default search provider as the user browses. But alternatively: - We could not do that and industriously keep the Chrome hardcoded list up to date. - Or we should ship hardcoded PNGs for Chrome's top 5 search providers. These two both seem unpalatable to me, but I'm mentioning them as alternatives (that we've previously rejected).
,
Oct 4
I just came across this as well by visiting finance.google.com (which redirects to https://www.google.com/search?stick=H4sIAAAAAAAAAOPQeMSozC3w8sc9YSmpSWtOXmMU4RJyy8xLzEtO9UnMS8nMSw9ITE_lAQCCiJIYKAAAAA&q=finance&tbm=fin&gws_rd=ssl). Looks like you can reset the omnibox to the usual "G" by doing a non-finance search. Adding pkotwicz@ for favicon knowledge, in case he has thoughts on this.
,
Oct 29
tommycli: please track the internal request to have Finance change their favicon and resolve this issue if and when they do.
,
Nov 26
Finance team changed the icon a few weeks ago. I just tested it and it is working correctly on my machine. I'm marking Fixed. This bug is ready for verification. |
||||
►
Sign in to add a comment |
||||
Comment 1 by k...@chromium.org
, Sep 12