ExtensionDisabledGlobalErrorTest.UninstallWhilePromptBeingShown is flaky |
||||||||||
Issue descriptionExtensionDisabledGlobalErrorTest.UninstallWhilePromptBeingShown is flaky in single_process_mash_browser_tests on linux_chromeos_dbg. Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=single_process_mash_browser_tests&tests=ExtensionDisabledGlobalErrorTest.UninstallWhilePromptBeingShown
,
Sep 12
,
Sep 12
,
Sep 12
ccing some Mash folks as I'm unsure how to triage this. This test only fails with in single_process_mash_browser_tests, so I think it's related to mash. Should I add this test to the blacklist?
,
Sep 12
Thanks for the heads up. Please do add it to the blacklist (chromeos.single_process_mash.browser_tests.filter) with a comment citing this bug, and keep the bug open/Available, we'll take a look. Thanks!
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5ddf8dd8cc4970137a2cd0fc7d4ab9fdf363385 commit a5ddf8dd8cc4970137a2cd0fc7d4ab9fdf363385 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Wed Sep 12 19:23:35 2018 Disable ExtensionDisabledGlobalErrorTest.UninstallWhilePromptBeingShown on mash single process Tbr: msw@chromium.org No-Try: true Bug: 883371 Change-Id: I8d3306719c3e74db0dd806f01c6a15011b436a7c Reviewed-on: https://chromium-review.googlesource.com/1222281 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#590781} [modify] https://crrev.com/a5ddf8dd8cc4970137a2cd0fc7d4ab9fdf363385/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
,
Sep 12
Thanks, I've added the test to the blacklist. Marking as available and removing sheriff label.
,
Oct 29
The flakiness dashboard link is no longer useful since the test is being skipped :/ I ran the test 25 times locally with no flakes (release w/dchecks). Perhaps we can re-enable to see if it's still flaky since there have been a lot of Mash fixes in the last 6 weeks.
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b68dde46a6048ababe2d30edf1d4c1879a84aa3a commit b68dde46a6048ababe2d30edf1d4c1879a84aa3a Author: Evan Stade <estade@chromium.org> Date: Mon Oct 29 19:49:31 2018 Mash: Re-enable a test which may no longer be flaky. test is ExtensionDisabledGlobalErrorTest.UninstallWhilePromptBeingShown Bug: 883371 Change-Id: I1ce860a5c25e9b6b791be681e98907aed9ffb9bc Reviewed-on: https://chromium-review.googlesource.com/c/1305873 Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#603591} [modify] https://crrev.com/b68dde46a6048ababe2d30edf1d4c1879a84aa3a/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
,
Oct 31
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b74072a0ef3004865cb0e4d73ea66bdd24acec18 commit b74072a0ef3004865cb0e4d73ea66bdd24acec18 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Wed Oct 31 18:39:41 2018 Revert "Mash: Re-enable a test which may no longer be flaky." This reverts commit b68dde46a6048ababe2d30edf1d4c1879a84aa3a. Reason for revert: The test is still flaky. Fails with same error as before. e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8629 Original change's description: > Mash: Re-enable a test which may no longer be flaky. > > test is ExtensionDisabledGlobalErrorTest.UninstallWhilePromptBeingShown > > Bug: 883371 > Change-Id: I1ce860a5c25e9b6b791be681e98907aed9ffb9bc > Reviewed-on: https://chromium-review.googlesource.com/c/1305873 > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603591} TBR=jamescook@chromium.org,estade@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 883371 Change-Id: I7b232b609a0f60a3c68c61822871ba8dadd6109f Reviewed-on: https://chromium-review.googlesource.com/c/1310506 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604348} [modify] https://crrev.com/b74072a0ef3004865cb0e4d73ea66bdd24acec18/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
,
Nov 7
Is this a result of bug 587199 ? The stack below[1] makes me think that the task posted by ExtensionInstallDialogView's |timer_| is racy. It's possible we could fix this by changing the base::Unretained to a weak ptr, but I have no way of verifying that since I can't trigger the flake locally. [1] [23286:23286:1031/055545.257722:FATAL:focus_controller.cc(238)] Check failed: rules_->CanFocusWindow(window, nullptr). #0 0x7f3bd48a551d base::debug::StackTrace::StackTrace() #1 0x7f3bd45a59da base::debug::StackTrace::StackTrace() #2 0x7f3bd4611cbe logging::LogMessage::~LogMessage() #3 0x7f3bb72a540c wm::FocusController::SetFocusedWindow() #4 0x7f3bb72a52e9 wm::FocusController::ResetFocusWithinActiveWindow() #5 0x7f3bcfb6e468 views::DesktopNativeWidgetAura::ClearNativeFocus() #6 0x7f3bcfb2705d views::Widget::ClearNativeFocus() #7 0x7f3bcfad1e69 views::FocusManager::ClearNativeFocus() #8 0x7f3bcfb0ff49 views::View::OnFocus() #9 0x7f3bcf9d40af views::InkDropHostView::OnFocus() #10 0x7f3bcfa056df views::Button::OnFocus() #11 0x7f3bcfa0d4ef views::LabelButton::OnFocus() #12 0x7f3bcfb0ffa0 views::View::Focus() #13 0x7f3bcfad1637 views::FocusManager::SetFocusedViewWithReason() #14 0x7f3bcf9ba592 views::FocusManager::SetFocusedView() #15 0x7f3bcfb0cc9e views::View::RequestFocus() #16 0x7f3bcfb3a3e0 views::DialogClientView::SetupLayout() #17 0x7f3bcfb38f29 views::DialogClientView::UpdateDialogButtons() #18 0x7f3bcfb39ab5 views::DialogClientView::OnDialogModelChanged() #19 0x7f3bcfb3bbc2 views::DialogDelegate::DialogModelChanged() #20 0x00000d60cbfc ExtensionInstallDialogView::EnableInstallButton() #21 0x000000b7565d _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_ #22 0x000000b755a4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_ #23 0x00000d614df5 _ZN4base8internal7InvokerINS0_9BindStateIM26ExtensionInstallDialogViewFvvEJNS0_17UnretainedWrapperIS3_EEEEEFvvEE7RunImplIRKS5_RKNSt3__15tupleIJS7_EEEJLm0EEEEvOT_OT0_NSE_16integer_sequenceImJXspT1_EEEE #24 0x00000d614d2c _ZN4base8internal7InvokerINS0_9BindStateIM26ExtensionInstallDialogViewFvvEJNS0_17UnretainedWrapperIS3_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #25 0x7f3bd455776e _ZNO4base12OnceCallbackIFvvEE3RunEv #26 0x7f3bd47f069b base::OneShotTimer::RunUserTask() #27 0x7f3bd47f0213 base::internal::TimerBase::RunScheduledTask() #28 0x7f3bd47f0da9 base::internal::BaseTimerTaskInternal::Run() #29 0x7f3bd45ec19d _ZN4base8internal13FunctorTraitsIMNS_19ImportantFileWriterEFvvEvE6InvokeIS4_PS2_JEEEvT_OT0_DpOT1_ #30 0x7f3bd45ec0e4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMNS_19ImportantFileWriterEFvvEJPS4_EEEvOT_DpOT0_ #31 0x7f3bd47f0f45 _ZN4base8internal7InvokerINS0_9BindStateIMNS0_21BaseTimerTaskInternalEFvvEJNS0_12OwnedWrapperIS3_EEEEEFvvEE7RunImplIS5_NSt3__15tupleIJS7_EEEJLm0EEEEvOT_OT0_NSC_16integer_sequenceImJXspT1_EEEE #32 0x7f3bd47f0e89 _ZN4base8internal7InvokerINS0_9BindStateIMNS0_21BaseTimerTaskInternalEFvvEJNS0_12OwnedWrapperIS3_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #33 0x7f3bd455776e _ZNO4base12OnceCallbackIFvvEE3RunEv #34 0x7f3bd45a6f0a base::debug::TaskAnnotator::RunTask() #35 0x7f3bd4639528 base::MessageLoop::RunTask() #36 0x7f3bd463982b base::MessageLoop::DeferOrRunPendingTask() #37 0x7f3bd4639f75 base::MessageLoop::DoDelayedWork() #38 0x7f3bd48f7590 base::MessagePumpLibevent::Run() #39 0x7f3bd4638cfe base::MessageLoop::Run() #40 0x7f3bd46e66a2 base::RunLoop::Run() #41 0x000007df54dc InProcessBrowserTest::RunUntilBrowserProcessQuits() #42 0x000007df78cc InProcessBrowserTest::QuitBrowsers() #43 0x000007df76eb InProcessBrowserTest::PostRunTestOnMainThread() #44 0x000009203e26 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #45 0x000000b7565d _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_ #46 0x000000b755a4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_ #47 0x0000092069d5 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #48 0x00000920690c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #49 0x000000b65cad _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #50 0x000007f5fadd ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #51 0x000007f5db48 ChromeBrowserMainParts::PreMainMessageLoopRun() #52 0x000003999c45 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #53 0x7f3bca0d032c content::BrowserMainLoop::PreMainMessageLoopRun() #54 0x7f3bc8c92b2d _ZN4base8internal13FunctorTraitsIMN7content12ChildProcessEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #55 0x7f3bc8c92a74 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content12ChildProcessEFvvEJPS5_EEEvOT_DpOT0_ #56 0x7f3bca0d6235 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #57 0x7f3bca0d616c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #58 0x7f3bc8b96abd _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #59 0x7f3bcb0bbecd content::StartupTaskRunner::RunAllTasksNow() #60 0x7f3bca0cbdef content::BrowserMainLoop::CreateStartupTasks() #61 0x7f3bca0d88f2 content::BrowserMainRunnerImpl::Initialize() #62 0x7f3bca0c3249 content::BrowserMain() #63 0x7f3bcc4036f0 content::RunBrowserProcessMain() #64 0x7f3bcc4062b9 content::ContentMainRunnerImpl::Run() #65 0x7f3bcc3fc50c content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #66 0x7f3ba0c4dd21 service_manager::Main() #67 0x7f3bcc400e25 content::ContentMain() #68 0x000009203142 content::BrowserTestBase::SetUp() #69 0x000007df482b InProcessBrowserTest::SetUp() #70 0x000007d17c1c extensions::ExtensionBrowserTest::SetUp() #71 0x000000bc3b2e _ZN7testing8internal12InvokeHelperIRKNSt3__16vectorIPN12user_manager4UserENS2_9allocatorIS6_EEEENS2_5tupleIJEEEE12InvokeMethodIN8chromeos15MockUserManagerEMSH_KFSB_vEEESB_PT_T0_RKSD_ #72 0x00000482dc92 testing::internal::HandleExceptionsInMethodIfSupported<>() #73 0x00000480e374 testing::Test::Run() #74 0x00000480ed75 testing::TestInfo::Run() #75 0x00000480fb2f testing::TestCase::Run() #76 0x0000048236b8 testing::internal::UnitTestImpl::RunAllTests() #77 0x00000483748e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #78 0x00000482f272 testing::internal::HandleExceptionsInMethodIfSupported<>() #79 0x000004823317 testing::UnitTest::Run() #80 0x000007e3e101 RUN_ALL_TESTS() #81 0x000007e3b2cb base::TestSuite::Run() #82 0x000007ceae57 ChromeTestSuiteRunner::RunTestSuite() #83 0x000007ceaf43 ChromeTestLauncherDelegate::RunTestSuite() #84 0x00000928c809 content::LaunchTests() #85 0x000007cec292 LaunchChromeTests()
,
Nov 12
ExtensionInstallDialogView::timer_ doesn't use SetTaskRunner() so it can't be related to bug 587199
,
Nov 15
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fc802de5f93d6cb89a4fbad464ef2b5e8a90068 commit 7fc802de5f93d6cb89a4fbad464ef2b5e8a90068 Author: Scott Violet <sky@chromium.org> Date: Wed Nov 21 19:14:14 2018 mus: makes showing/hiding WindowTreeHost's window same as Widget This patch makes showing/hiding the WindowTreeHost's window behave the same as if Widget Show/Hide was called. This is necessary for transient windows to work. In particular it's expected that hiding the transient parent hides transient children. TransientWindowManager does that by way of calling show/hide directly on the aura window. I could have added the ability to inject function to accomplish that, but I know I've run into other code expecting show/hide on the aura window to map to showing/hiding the widget. BUG= 883371 TEST=covered by tests Change-Id: I6ee9009732ba1b5f47e888a1a841f462a1f5a851 Reviewed-on: https://chromium-review.googlesource.com/c/1340964 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#610126} [modify] https://crrev.com/7fc802de5f93d6cb89a4fbad464ef2b5e8a90068/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter [modify] https://crrev.com/7fc802de5f93d6cb89a4fbad464ef2b5e8a90068/ui/views/mus/desktop_window_tree_host_mus.cc [modify] https://crrev.com/7fc802de5f93d6cb89a4fbad464ef2b5e8a90068/ui/views/mus/desktop_window_tree_host_mus.h [modify] https://crrev.com/7fc802de5f93d6cb89a4fbad464ef2b5e8a90068/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
,
Nov 21
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by adithyas@chromium.org
, Sep 12