This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Hi cindyb@ and geohsu@, The CLs only increase days-before-hard-failure for some checks and should be totally safe to land. I'm pretty sure they won't break anything.

CLs are here:

https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1222150
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1222151

does the stale check even make sense on branches ?  the kernel versions are basically fixed at branch time.

Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/74de15e6fac8c7b43a4764341ed1617f8858242e

commit 74de15e6fac8c7b43a4764341ed1617f8858242e
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Thu Sep 13 17:20:12 2018

afdo: extend allowed ages of kernel afdo profiles by 2 weeks

TEST=afdo_unittest, afdo_stage_unittest
BUG= chromium:883368 

Change-Id: I21231bdddf1009ac2460b012cb6ac89d890c8642
Reviewed-on: https://chromium-review.googlesource.com/1222106
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
(cherry picked from commit 6d7245a03cbbe4e16b198891ee43be203a6633ba)
Reviewed-on: https://chromium-review.googlesource.com/1222150

[modify] https://crrev.com/74de15e6fac8c7b43a4764341ed1617f8858242e/cbuildbot/afdo.py

vapier, is there a way to know in chromite to check canary vs branches?

#5: I totally agree but will let Luis and Manoj decide it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9ce808ac0387e3c4bb8d37eb9d7d379133d30e9d

commit 9ce808ac0387e3c4bb8d37eb9d7d379133d30e9d
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Thu Sep 13 17:32:59 2018

afdo: extend allowed ages of kernel afdo profiles by 2 weeks

TEST=afdo_unittest, afdo_stage_unittest
BUG= chromium:883368 

Change-Id: I21231bdddf1009ac2460b012cb6ac89d890c8642
Reviewed-on: https://chromium-review.googlesource.com/1222106
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
(cherry picked from commit 6d7245a03cbbe4e16b198891ee43be203a6633ba)
Reviewed-on: https://chromium-review.googlesource.com/1222151

[modify] https://crrev.com/9ce808ac0387e3c4bb8d37eb9d7d379133d30e9d/cbuildbot/afdo.py

i think we should be able to communicate whether cbuildbot is building the latest master or a branch, but at the very least, we could add an explicit knob to the config like "afdo_kernel_lifespan" which master would set to 2 weeks, but branches would set to None and that'd cause the check to be skipped.

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot