response headers should be persisted so they can be used when the download service resumes a request in a new browser session
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee615c54c537ef2f3f58fa761ef4e81384b7548c commit ee615c54c537ef2f3f58fa761ef4e81384b7548c Author: Rayan Kanso <rayankans@chromium.org> Date: Mon Sep 17 12:24:42 2018 Store response headers and url chain in download::Entry This allows for downloads that resume on startup to still have access to that information. Bug: 883359, 881314 Change-Id: I65ff163180f8b834ca59fadba0f45d8536d13be5 Reviewed-on: https://chromium-review.googlesource.com/1222893 Reviewed-by: Xing Liu <xingliu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#591649} [modify] https://crrev.com/ee615c54c537ef2f3f58fa761ef4e81384b7548c/components/download/internal/background_service/controller_impl.cc [modify] https://crrev.com/ee615c54c537ef2f3f58fa761ef4e81384b7548c/components/download/internal/background_service/entry.cc [modify] https://crrev.com/ee615c54c537ef2f3f58fa761ef4e81384b7548c/components/download/internal/background_service/entry.h [modify] https://crrev.com/ee615c54c537ef2f3f58fa761ef4e81384b7548c/components/download/internal/background_service/entry_utils.cc [modify] https://crrev.com/ee615c54c537ef2f3f58fa761ef4e81384b7548c/components/download/internal/background_service/proto/entry.proto [modify] https://crrev.com/ee615c54c537ef2f3f58fa761ef4e81384b7548c/components/download/internal/background_service/proto_conversions.cc [modify] https://crrev.com/ee615c54c537ef2f3f58fa761ef4e81384b7548c/components/download/internal/background_service/test/entry_utils.cc [modify] https://crrev.com/ee615c54c537ef2f3f58fa761ef4e81384b7548c/components/download/public/background_service/download_metadata.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07 commit 44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07 Author: Xing Liu <xingliu@chromium.org> Date: Wed Sep 19 02:32:04 2018 Background download: Retry when no response header is persisted. We persist download response headers and url chain when OnDownloadCreated is called. This CL does the following: 1. If the persist failed during ACTIVE state, delete the driver and the file to let the download service to retry. 2. Change DownloadDriver::Remove to be able to remove file for completed download. 3. Add did_receive_response in entry proto, since some protocol or a socket error may cause the response headers to be empty. We should validate the entry state with this flag instead of response headers. TBR=carlosk@chromium.org Bug: 883359, 881314 Change-Id: I560cc478b5d1f12c33b56b94ee97cbb1d2b76c3d Reviewed-on: https://chromium-review.googlesource.com/1227290 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592306} [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/content/internal/download_driver_impl.cc [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/content/internal/download_driver_impl.h [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/content/internal/download_driver_impl_unittest.cc [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/internal/background_service/controller_impl.cc [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/internal/background_service/controller_impl_unittest.cc [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/internal/background_service/download_driver.h [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/internal/background_service/entry.cc [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/internal/background_service/entry.h [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/internal/background_service/entry_utils.cc [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/internal/background_service/in_memory_download_driver.cc [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/internal/background_service/in_memory_download_driver.h [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/internal/background_service/in_memory_download_driver_unittest.cc [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/internal/background_service/proto/entry.proto [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/internal/background_service/proto_conversions.cc [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/internal/background_service/test/entry_utils.cc [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/internal/background_service/test/test_download_driver.cc [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/internal/background_service/test/test_download_driver.h [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/public/background_service/download_metadata.cc [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/public/background_service/download_metadata.h [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/public/background_service/test/test_download_service.cc [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/download/public/common/download_item.h [modify] https://crrev.com/44dfb9f4a9439707d5a1e8a8bb92fa8f9fd15a07/components/offline_pages/core/prefetch/test_download_service.cc
Comment 1 by bugdroid1@chromium.org
, Sep 17