New issue
Advanced search Search tips

Issue 883357 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

cros_component: improve build_component.py

Project Member Reported by xiaochu@chromium.org, Sep 12

Issue description

1. allow create&upload a zip file even when current served package is most up-to-date
2. show prompts (Are you sure to upload? Once zip file is uploaded, it can not be modified in any way.) before upload to confirm.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/991fdf38e7b067401e10e962ab7258acae0c4a37

commit 991fdf38e7b067401e10e962ab7258acae0c4a37
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Tue Sep 18 21:04:18 2018

cros_component: show warnings upon upload

Once a new component release is uploaded to gs bucket, Omaha picks it up
and never scan it again. So any modification to the release after upload
does not have effect.

We show a warning before the upload operation and prompt user to input
'Yes' to actuall upload to the repo.

BUG= chromium:883357 
TEST=manual testing

Change-Id: Idf888ef31c6b11080d242cf21b687061f9b2046e
Reviewed-on: https://chromium-review.googlesource.com/1222526
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/991fdf38e7b067401e10e962ab7258acae0c4a37/cros_component/build_component.py

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/539a8c829d472a9dc309411408a2996d1a1536b1

commit 539a8c829d472a9dc309411408a2996d1a1536b1
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Fri Sep 28 02:45:19 2018

cros_component: remove package version check

Package version is used to track package changes and should not be
changed without touching the package source.

A bad release process (missing manifest file, wrong component content,
etc.) may require a new release to be pushed for the same package version.

So let's allow re-upload of same package version to new releases.

BUG= chromium:883357 
TEST=manual testing

Change-Id: I028a9a84c5d3b9f1d26bae90a3c31b1c84107f89
Reviewed-on: https://chromium-review.googlesource.com/1222567
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/539a8c829d472a9dc309411408a2996d1a1536b1/cros_component/build_component.py

Status: Fixed (was: Untriaged)

Sign in to add a comment