Issue metadata
Sign in to add a comment
|
[Windows] Microphone list under settings is not correct |
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3538.16 OS: Windows 10 Hp Spectre What steps will reproduce the problem? Pre-condition: Add more one or two headsets [I used a 3.5 jack and a USB headset] (1)Open any webrtc apps like classic hangouts or meet. (2)Perform a call (3)Click Settings [hangouts] or Three dots [meet] (4)Check the available microphones What is the expected result? Should list all the microphones connected to the device and the names of it should be displayed [For eg. Planteronics USB headset] What happens instead? Displays Communications and Default for all scenarios. It use to show Default-Internal or External etc. Does this work for other platforms? Yes verified in Macbook, Linux etc. This happens only in Windows 10 Hp Spectre.
,
Sep 13
That don't look right. Is the problem the same if you run with: --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox --disable-features=WebRtcApmInAudioService
,
Sep 13
Thank you Oskar. After using the new flag it looks the same as withflag.png file.
,
Sep 13
I'm going to bounce this to Marina for now, as it might be sandboxing issue specifically on Windows.
,
Sep 13
Oh. Vasan, is it the same problem if you run with: --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess --disable-features=WebRtcApmInAudioService,AudioServiceSandbox
,
Sep 13
,
Sep 24
Getting device name fails when running sandboxed. IPropertyStore::GetValue returns 0xe000020b here: https://cs.chromium.org/chromium/src/media/audio/win/core_audio_util_win.cc?rcl=49bd0e64188e49be0c9061f75b75190accc72a05&l=215
,
Oct 2
Still grinding on this one, summarized my progress in [1], any suggestions on what else to try are very welcome. [1] https://docs.google.com/document/d/1whqrOr3j-oByjZKfvy_bBGMXz3pLP0iQALiqCTjUb0c/edit?usp=sharing
,
Oct 2
Does it also happen in: https://webrtc.github.io/samples/src/content/devices/input-output/
,
Oct 2
Fix under review: https://chromium-review.googlesource.com/c/chromium/src/+/1256828
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b20112dca79d2c9f951fc0bc780e171179c00a45 commit b20112dca79d2c9f951fc0bc780e171179c00a45 Author: Marina Ciocea <marinaciocea@chromium.org> Date: Tue Oct 02 22:11:10 2018 Allow kernel driver access for audio sandbox. In default sandbox policy handles to kernel drivers are closed [1][2]. In order to allow audio service to access device properties (such as friendly name as reported by linked bug), disable default policy for audio sandbox and configure a customized default policy on audio sandbox PreSpawn. [1] https://cs.chromium.org/chromium/src/services/service_manager/sandbox/win/sandbox_win.cc?rcl=a35a7fe2bea84fe913ea585ba642357279e0a5cf&l=418 [2] https://cs.chromium.org/chromium/src/services/service_manager/sandbox/win/sandbox_win.cc?rcl=a35a7fe2bea84fe913ea585ba642357279e0a5cf&l=932 Bug: 883326 Change-Id: I676f6820a0c1a4e5bd02bf7e66bec9764fc36731 Reviewed-on: https://chromium-review.googlesource.com/c/1256828 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#596001} [modify] https://crrev.com/b20112dca79d2c9f951fc0bc780e171179c00a45/content/browser/utility_process_host.cc [modify] https://crrev.com/b20112dca79d2c9f951fc0bc780e171179c00a45/services/audio/audio_sandbox_win.cc
,
Oct 3
Requesting merge for the change in #13. It's a low-risk change addressing an issue with audio sandbox.
,
Oct 3
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 3
Unable to reproduce the issue on reported chrome version #70.0.3538.16 using Windows 10 by following below steps. Steps: ===== 1.Launched chrome using command prompt by --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox,WebRtcApmInAudioService. 2.Logged into the gmail account. 3.Made a hangouts call. 4.Under settings observed the list of microphones with names. Note: Could not find any difference with and without enabling flags. Attached screenshots for reference. @Marina: Could you please verify the above screenshots and help us in verifying the fix. Thanks.!
,
Oct 3
That's probably because device names are cached. You can try one of the following: - plug/unplug a device - change default device in windows sound settings
,
Oct 3
Btw, since sandbox is currently enabled in some experiment groups, make sure to disable the flag when you don't want to use it. Compare: --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox,WebRtcApmInAudioService against: --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess --disable-features=WebRtcApmInAudioService,AudioServiceSandbox
,
Oct 3
,
Oct 4
swarnasree.mukkala@, did you manage to try out the issue?
,
Oct 4
,
Oct 4
Unable to reproduce the issue as per comment#18, on reported chrome version #70.0.3538.16 using Windows 10. Please follow below for observations. Observations: =========== 1.When flag is enabled by "--enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox,WebRtcApmInAudioService", observed that the microphone list was not displayed. 2.When the flag is disable by " --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess --disable-features=WebRtcApmInAudioService,AudioServiceSandbox", observed that the list of microphone was displayed. Note: Cleared cache while testing both scenarios. Attached screenshots for reference. marinaciocea@ : Please verify the above screenshots and let us know if anything is being missed from our end. Thanks.!
,
Oct 4
@swarna: The fix has been landed in 71.0.3568.0. Kindly verify in that build or later builds. Source: https://chromiumdash.appspot.com/commits?user=marinaciocea%40chromium.org&platform=Android
,
Oct 4
swarnasree.mukkala@, in the screenshots you shared in #20 you managed to reproduce the issue - in the with_flag version device names are not displayed correctly and less devices are displayed. Please verify that the issue is fixed by #13 change in M71 build, version 71.0.3569.0+.
,
Oct 4
,
Oct 4
Looks good! I have verified the issue in 71.0.3569.0 in Asus win 10 UX430U model. Thanks for the fix Marina.
,
Oct 4
Awesome! Thank you, Vasan!
,
Oct 4
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a214c7d4f7a2a6d034321a1fd5437baa54a4fc3f commit a214c7d4f7a2a6d034321a1fd5437baa54a4fc3f Author: Marina Ciocea <marinaciocea@chromium.org> Date: Thu Oct 04 19:54:49 2018 [M70] Allow kernel driver access for audio sandbox. In default sandbox policy handles to kernel drivers are closed [1][2]. In order to allow audio service to access device properties (such as friendly name as reported by linked bug), disable default policy for audio sandbox and configure a customized default policy on audio sandbox PreSpawn. [1] https://cs.chromium.org/chromium/src/services/service_manager/sandbox/win/sandbox_win.cc?rcl=a35a7fe2bea84fe913ea585ba642357279e0a5cf&l=418 [2] https://cs.chromium.org/chromium/src/services/service_manager/sandbox/win/sandbox_win.cc?rcl=a35a7fe2bea84fe913ea585ba642357279e0a5cf&l=932 TBR=marinaciocea@chromium.org (cherry picked from commit b20112dca79d2c9f951fc0bc780e171179c00a45) Bug: 883326 Change-Id: I676f6820a0c1a4e5bd02bf7e66bec9764fc36731 Reviewed-on: https://chromium-review.googlesource.com/c/1256828 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: James Forshaw <forshaw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#596001} Reviewed-on: https://chromium-review.googlesource.com/c/1262635 Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#863} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/a214c7d4f7a2a6d034321a1fd5437baa54a4fc3f/content/browser/utility_process_host.cc [modify] https://crrev.com/a214c7d4f7a2a6d034321a1fd5437baa54a4fc3f/services/audio/audio_sandbox_win.cc
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a214c7d4f7a2a6d034321a1fd5437baa54a4fc3f Commit: a214c7d4f7a2a6d034321a1fd5437baa54a4fc3f Author: marinaciocea@chromium.org Commiter: marinaciocea@chromium.org Date: 2018-10-04 19:54:49 +0000 UTC [M70] Allow kernel driver access for audio sandbox. In default sandbox policy handles to kernel drivers are closed [1][2]. In order to allow audio service to access device properties (such as friendly name as reported by linked bug), disable default policy for audio sandbox and configure a customized default policy on audio sandbox PreSpawn. [1] https://cs.chromium.org/chromium/src/services/service_manager/sandbox/win/sandbox_win.cc?rcl=a35a7fe2bea84fe913ea585ba642357279e0a5cf&l=418 [2] https://cs.chromium.org/chromium/src/services/service_manager/sandbox/win/sandbox_win.cc?rcl=a35a7fe2bea84fe913ea585ba642357279e0a5cf&l=932 TBR=marinaciocea@chromium.org (cherry picked from commit b20112dca79d2c9f951fc0bc780e171179c00a45) Bug: 883326 Change-Id: I676f6820a0c1a4e5bd02bf7e66bec9764fc36731 Reviewed-on: https://chromium-review.googlesource.com/c/1256828 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: James Forshaw <forshaw@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#596001} Reviewed-on: https://chromium-review.googlesource.com/c/1262635 Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#863} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vasanthakumar@chromium.org
, Sep 12Summary: [Windows] Microphone list under settings is not correct (was: [Windows] Microphone list under settings not correct )