New issue
Advanced search Search tips

Issue 883322 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 7
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Create cluster telemetry loading benchmark

Project Member Reported by cbruni@chromium.org, Sep 12

Issue description

Add a CT benchmark that includes most of the v8.browsing metrics.
The current set of metrics allow only a poor indication of V8's performance.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/8dd2f281c62edea851b3b68ddff43408076445af

commit 8dd2f281c62edea851b3b68ddff43408076445af
Author: Camillo Bruni <cbruni@chromium.org>
Date: Thu Sep 13 12:03:21 2018

Add more helpers in preparation for v8.loading.cluster_telemetry benchmark

- AddFilter on ChromeTraceCategoryFilter
- AddTraceCategoryFilter and ExtendTimelineBasedMetric on Options

Bug:  chromium:883322 
Change-Id: Ia627d944033f8458d117b112c529e5b6181bf904
Reviewed-on: https://chromium-review.googlesource.com/1221549
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/8dd2f281c62edea851b3b68ddff43408076445af/telemetry/telemetry/web_perf/timeline_based_measurement.py
[modify] https://crrev.com/8dd2f281c62edea851b3b68ddff43408076445af/telemetry/telemetry/timeline/chrome_trace_category_filter_unittest.py
[modify] https://crrev.com/8dd2f281c62edea851b3b68ddff43408076445af/telemetry/telemetry/timeline/chrome_trace_category_filter.py

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e40ef3866f085d2c6b25183968531edcb85e05c

commit 7e40ef3866f085d2c6b25183968531edcb85e05c
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Sep 13 14:41:38 2018

Roll src/third_party/catapult 3e071665b9f9..c4d326feb2ff (5 commits)

https://chromium.googlesource.com/catapult.git/+log/3e071665b9f9..c4d326feb2ff


git log 3e071665b9f9..c4d326feb2ff --date=short --no-merges --format='%ad %ae %s'
2018-09-13 anthonyalridge@google.com Add clip path at to prevent overlap with x axis label.
2018-09-13 wangge@google.com Add functions to include APK, generate isolate and upload it.
2018-09-13 cbruni@chromium.org Add more helpers in preparation for v8.loading.cluster_telemetry benchmark
2018-09-13 anthonyalridge@google.com Add padding to numeric labels for stacked bar plotter.
2018-09-13 ulan@chromium.org Output DevTools error messages as warnings while running a story.


Created with:
  gclient setdep -r src/third_party/catapult@c4d326feb2ff

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:866423, chromium:863390 , chromium:883322 ,chromium:866423,chromium:880432
TBR=sullivan@chromium.org

Change-Id: I68916abd79b995d8c990f4fc64c65dce5cdbaa23
Reviewed-on: https://chromium-review.googlesource.com/1224473
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591005}
[modify] https://crrev.com/7e40ef3866f085d2c6b25183968531edcb85e05c/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/393391985b970fe0f33952d108f2470c8d1fdb83

commit 393391985b970fe0f33952d108f2470c8d1fdb83
Author: Darren Shen <shend@chromium.org>
Date: Fri Sep 14 02:00:31 2018

Revert "Roll src/third_party/catapult 3e071665b9f9..c4d326feb2ff (5 commits)"

This reverts commit 7e40ef3866f085d2c6b25183968531edcb85e05c.

Reason for revert: 883892

Original change's description:
> Roll src/third_party/catapult 3e071665b9f9..c4d326feb2ff (5 commits)
>
> https://chromium.googlesource.com/catapult.git/+log/3e071665b9f9..c4d326feb2ff
>
>
> git log 3e071665b9f9..c4d326feb2ff --date=short --no-merges --format='%ad %ae %s'
> 2018-09-13 anthonyalridge@google.com Add clip path at to prevent overlap with x axis label.
> 2018-09-13 wangge@google.com Add functions to include APK, generate isolate and upload it.
> 2018-09-13 cbruni@chromium.org Add more helpers in preparation for v8.loading.cluster_telemetry benchmark
> 2018-09-13 anthonyalridge@google.com Add padding to numeric labels for stacked bar plotter.
> 2018-09-13 ulan@chromium.org Output DevTools error messages as warnings while running a story.
>
>
> Created with:
>   gclient setdep -r src/third_party/catapult@c4d326feb2ff
>
> The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
>
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
>
> BUG=chromium:866423, chromium:863390 , chromium:883322 ,chromium:866423,chromium:880432
> TBR=sullivan@chromium.org
>
> Change-Id: I68916abd79b995d8c990f4fc64c65dce5cdbaa23
> Reviewed-on: https://chromium-review.googlesource.com/1224473
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#591005}

TBR=sullivan@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com

Change-Id: Iacf4973a98666f6030cb3373629cefdfc58f95e2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:866423,  chromium:863390 ,  chromium:883322 , chromium:880432
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1226534
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591261}
[modify] https://crrev.com/393391985b970fe0f33952d108f2470c8d1fdb83/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8323f92cb0c81332c00abfe5a3bad012a400fd35

commit 8323f92cb0c81332c00abfe5a3bad012a400fd35
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Sep 14 16:52:21 2018

Roll src/third_party/catapult 3e071665b9f9..9f36d9f78813 (14 commits)

https://chromium.googlesource.com/catapult.git/+log/3e071665b9f9..9f36d9f78813


git log 3e071665b9f9..9f36d9f78813 --date=short --no-merges --format='%ad %ae %s'
2018-09-14 pasko@chromium.org FlushOsPageCaches: wait for dust to settle
2018-09-14 ulan@chromium.org Revert "Output DevTools error messages as warnings while running a story."
2018-09-13 simonhatch@chromium.org Dashboard - Error out on empty or uncompressed uploads
2018-09-13 sadrul@chromium.org rendering: Ignore trace-events for canceled draws.
2018-09-13 vovoy@chromium.org Only download files for filtered stories in story_runner
2018-09-13 chiniforooshan@chromium.org Telemetry: fix a SF stats collector bug
2018-09-13 cbruni@chromium.org Include hash for wprgo archive names to reduce name collisions
2018-09-13 pasko@chromium.org clear_system_cache: update binaries
2018-09-13 anthonyalridge@google.com Create a link to traces from the CFG.
2018-09-13 anthonyalridge@google.com Add clip path at to prevent overlap with x axis label.
2018-09-13 wangge@google.com Add functions to include APK, generate isolate and upload it.
2018-09-13 cbruni@chromium.org Add more helpers in preparation for v8.loading.cluster_telemetry benchmark
2018-09-13 anthonyalridge@google.com Add padding to numeric labels for stacked bar plotter.
2018-09-13 ulan@chromium.org Output DevTools error messages as warnings while running a story.


Created with:
  gclient setdep -r src/third_party/catapult@9f36d9f78813

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:811244, chromium:881384 , chromium:883892 ,chromium:880432, chromium:883735 ,chromium:883592, chromium:882291 , chromium:881873 ,chromium:878390, chromium:881384 ,chromium:866423,chromium:866423, chromium:863390 , chromium:883322 ,chromium:866423,chromium:880432
TBR=sullivan@chromium.org

Change-Id: I934e7e9b842518c75edbeb4a1604c2e06b577861
Reviewed-on: https://chromium-review.googlesource.com/1226380
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#591375}
[modify] https://crrev.com/8323f92cb0c81332c00abfe5a3bad012a400fd35/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b3b453719bb05f44a9c5d189f4d40d6cabae79f

commit 8b3b453719bb05f44a9c5d189f4d40d6cabae79f
Author: Camillo Bruni <cbruni@chromium.org>
Date: Tue Sep 18 19:07:03 2018

[cluster_telemetry] Add v8.loading.cluster_telemetry benchmark

The new benchmark takes all the metrics from the v8.browsing benchmarks and
provides an additional --enable-rcs to switch on the more expensive runtime
call stats metrics.

- Introduce new _LoadingBaseClusterTelemetry base class
- Introduce AugmentOptionsForV8BrowsingMetrics and V8BrowsingShouldAddValue
  helpers to share metrics setup code with v8.browsing benchmarks
- Add new V8LoadingClusterTelemetry benchmark

Bug:  chromium:883322 
Change-Id: I67287fb046993a4cb687ac57073f81a7c006d361
Reviewed-on: https://chromium-review.googlesource.com/1224448
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592134}
[modify] https://crrev.com/8b3b453719bb05f44a9c5d189f4d40d6cabae79f/tools/perf/benchmarks/v8_browsing.py
[add] https://crrev.com/8b3b453719bb05f44a9c5d189f4d40d6cabae79f/tools/perf/contrib/cluster_telemetry/loading_base_ct.py
[modify] https://crrev.com/8b3b453719bb05f44a9c5d189f4d40d6cabae79f/tools/perf/contrib/cluster_telemetry/loading_ct.py
[add] https://crrev.com/8b3b453719bb05f44a9c5d189f4d40d6cabae79f/tools/perf/contrib/cluster_telemetry/v8_loading_ct.py
[modify] https://crrev.com/8b3b453719bb05f44a9c5d189f4d40d6cabae79f/tools/perf/validate_wpr_archives

Status: Assigned (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c82e8f0fca294d41845857bd31ff6ebc4c6ba485

commit c82e8f0fca294d41845857bd31ff6ebc4c6ba485
Author: Camillo Bruni <cbruni@chromium.org>
Date: Tue Oct 23 12:26:59 2018

[cluster_telemetry] Add separate v8.loading_runtime_stats benchmark

Conditionally enablding runtime call stats is not straight forward. Hence we
add a separate benchmark that uses the slow RCS metrics.

Bug:  chromium:883322 
Change-Id: I66bc754f59ea62f0b7a922a3ca22535f568597d7
Reviewed-on: https://chromium-review.googlesource.com/c/1294034
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#601911}
[modify] https://crrev.com/c82e8f0fca294d41845857bd31ff6ebc4c6ba485/tools/perf/contrib/cluster_telemetry/v8_loading_ct.py
[add] https://crrev.com/c82e8f0fca294d41845857bd31ff6ebc4c6ba485/tools/perf/contrib/cluster_telemetry/v8_loading_runtime_stats_ct.py
[modify] https://crrev.com/c82e8f0fca294d41845857bd31ff6ebc4c6ba485/tools/perf/validate_wpr_archives

Status: Fixed (was: Assigned)

Sign in to add a comment