This series of steps will run after the "deapply patch" steps. It will roll tip of tree, reapply the patch, and then run the failing tests. If the same tests fail as the original, then the build is marked as a failure. Otherwise, the build is marked as a success.
See design doc for more details: https://docs.google.com/document/d/1YF3SAd7f9ekiwV-6CxYsf7f0FthY6ClAw9znS7N8xU0/edit#
Due to a typo in the CL description, this CL failed to get posted to the bug when committed:
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1222326
"""
Add comments to chromium_tests trybot methods.
This CL has no functional change.
This CL adds detailed comments for the _trybot_steps_internal and
run_tests_on_tryserver in preparation for future refactors.
"""
Hi, is it possible that one of these patches are affecting https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_archive_rel_ng?
If yes, it is blocking the WebRTC roll into Chromium.
On 2018-09-14 we had the last green run:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_archive_rel_ng/2198
And since that we see a failure in the "without patch" part:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_archive_rel_ng/2201
This is the error message:
Traceback (most recent call last):
File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_engine/run.py", line 287, in _new_run
recipe_result = recipe_script.run(api, self.properties, self.environ)
File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_engine/loader.py", line 108, in run
self.run_steps, properties, environ, self.PROPERTIES, api=api)
File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_engine/loader.py", line 636, in invoke_with_properties
arg_names, **additional_args)
File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_engine/loader.py", line 599, in _invoke_with_properties
return callable_obj(*props, **additional_args)
File "/b/s/w/ir/kitchen-checkout/build/scripts/slave/recipes/chromium_trybot.py", line 46, in RunSteps
return api.chromium_tests.trybot_steps()
File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_engine/recipe_api.py", line 765, in _inner
return func(*a, **kw)
File "/b/s/w/ir/kitchen-checkout/build/scripts/slave/recipe_modules/chromium_tests/api.py", line 1110, in trybot_steps
enable_retry_with_patch=enable_retry_with_patch)
File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_engine/recipe_api.py", line 765, in _inner
return func(*a, **kw)
File "/b/s/w/ir/kitchen-checkout/build/scripts/slave/recipe_modules/chromium_tests/api.py", line 897, in _run_tests_on_tryserver
self.m.test_utils.run_tests(self.m, failing_tests, 'without patch')
File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_engine/recipe_api.py", line 765, in _inner
return func(*a, **kw)
File "/b/s/w/ir/kitchen-checkout/build/scripts/slave/recipe_modules/test_utils/api.py", line 159, in run_tests
t.run(caller_api, suffix)
File "/b/s/w/ir/kitchen-checkout/build/scripts/slave/recipe_modules/chromium_tests/steps.py", line 499, in run
'--filter-file', api.json.input(tests_to_retry)
File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_engine/recipe_api.py", line 765, in _inner
return func(*a, **kw)
File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_engine/util.py", line 135, in inner
ret = static_call(self, func, *args, **kwargs)
File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_engine/util.py", line 122, in static_call
return func(obj, *args, **kwargs)
File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_modules/json/api.py", line 105, in input
return self.m.raw_io.input_text(self.dumps(data), '.json')
File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_modules/json/api.py", line 20, in dumps
return json.dumps(*args, **kwargs)
File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/json/__init__.py", line 251, in dumps
sort_keys=sort_keys, **kw).encode(obj)
File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/json/encoder.py", line 209, in encode
chunks = list(chunks)
File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/json/encoder.py", line 442, in _iterencode
o = _default(o)
File "/b/s/w/ir/kitchen-checkout/recipe_engine/recipe_engine/config_types.py", line 26, in json_fixup
raise TypeError("%r is not JSON serializable" % obj)
TypeError: set(['mac-release/sizes/chrome-si/initializers']) is not JSON serializable
Hi -- it looks like the root problem is that the sizes step is failing. [both with and without patch]
There appears to be a second problem wherein the recipe is trying to serialize a set() to a JSON. I'll look into that.
Deleted:
Screen Shot 2018-09-18 at 9.29.46 AM.png
768 KB
Comment 1 by erikc...@chromium.org
, Sep 12