The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1b483974b7019cbe80f2c359647b043f108070d

commit f1b483974b7019cbe80f2c359647b043f108070d
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Thu Sep 13 12:39:57 2018

[Password Generation] Add the metric for the number generated passwords
vs manually typed passwords.

The metric counts only newly created passwords.

Bug: 883319
Change-Id: I6f3646d08f8b4aed163ddfb3cbb7e0cb58162def
Reviewed-on: https://chromium-review.googlesource.com/1221322
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590983}
[modify] https://crrev.com/f1b483974b7019cbe80f2c359647b043f108070d/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/f1b483974b7019cbe80f2c359647b043f108070d/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/f1b483974b7019cbe80f2c359647b043f108070d/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/f1b483974b7019cbe80f2c359647b043f108070d/tools/metrics/histograms/histograms.xml

It is just adding new metric.

The bug is marked as P3 or Feature. It should not be merged as M70 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d7788b0380512e5436370d5e100da0273345429

commit 3d7788b0380512e5436370d5e100da0273345429
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Thu Nov 15 18:17:02 2018

Log metrics about the password dropdown.

- When the dropdown is shown we record if password generation is available.
- The type of the chosen suggestion is recorded.

Bug: 883319
Change-Id: I69ac20b4022707cbcb57164b8718feecf85ab83a
Reviewed-on: https://chromium-review.googlesource.com/c/1335605
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608440}
[modify] https://crrev.com/3d7788b0380512e5436370d5e100da0273345429/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/3d7788b0380512e5436370d5e100da0273345429/components/password_manager/core/browser/password_autofill_manager_unittest.cc
[modify] https://crrev.com/3d7788b0380512e5436370d5e100da0273345429/components/password_manager/core/browser/password_manager_metrics_util.cc
[modify] https://crrev.com/3d7788b0380512e5436370d5e100da0273345429/components/password_manager/core/browser/password_manager_metrics_util.h
[modify] https://crrev.com/3d7788b0380512e5436370d5e100da0273345429/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3d7788b0380512e5436370d5e100da0273345429/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fcb6ac127a39bcf86abcf0ff150fb4e72744a9d

commit 8fcb6ac127a39bcf86abcf0ff150fb4e72744a9d
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Wed Jan 09 10:01:44 2019

[Password Geneation] Fix metric about generated password changes

A generated password was considered changed even if a username or another field on a form was changed. Only password changes should be considred.

Bug: 883319
Change-Id: If8cf623370abe0f02410d01d646685a7b2d843c3
Reviewed-on: https://chromium-review.googlesource.com/c/1400810
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621097}
[modify] https://crrev.com/8fcb6ac127a39bcf86abcf0ff150fb4e72744a9d/components/password_manager/core/browser/new_password_form_manager.cc
[modify] https://crrev.com/8fcb6ac127a39bcf86abcf0ff150fb4e72744a9d/components/password_manager/core/browser/new_password_form_manager_unittest.cc

This is just 1-line change in how metrics are collected. It can affect only on metrics collection. We would like to fix the metric asap. The change is covered by tests.

This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving merge to M72 branch 3626 based on comment #7. Please merge ASAP so we can pick it up for next beta release. Thank you.

Pls merge your change to M72 branch 3626 latest by 1:00 PM PT, Monday (11/14) so we can pick it up for next week beta release. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a3848924340e57fbd50974e6de86679716281c0

commit 0a3848924340e57fbd50974e6de86679716281c0
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Mon Jan 14 08:12:52 2019

[Password Geneation] Fix metric about generated password changes

A generated password was considered changed even if a username or another field on a form was changed. Only password changes should be considred.

Bug: 883319
Change-Id: If8cf623370abe0f02410d01d646685a7b2d843c3
Reviewed-on: https://chromium-review.googlesource.com/c/1400810
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#621097}(cherry picked from commit 8fcb6ac127a39bcf86abcf0ff150fb4e72744a9d)
Reviewed-on: https://chromium-review.googlesource.com/c/1408868
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#657}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/0a3848924340e57fbd50974e6de86679716281c0/components/password_manager/core/browser/new_password_form_manager.cc
[modify] https://crrev.com/0a3848924340e57fbd50974e6de86679716281c0/components/password_manager/core/browser/new_password_form_manager_unittest.cc

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/0a3848924340e57fbd50974e6de86679716281c0

Commit: 0a3848924340e57fbd50974e6de86679716281c0
Author: kolos@chromium.org
Commiter: kolos@chromium.org
Date: 2019-01-14 08:12:52 +0000 UTC

[Password Geneation] Fix metric about generated password changes

A generated password was considered changed even if a username or another field on a form was changed. Only password changes should be considred.

Bug: 883319
Change-Id: If8cf623370abe0f02410d01d646685a7b2d843c3
Reviewed-on: https://chromium-review.googlesource.com/c/1400810
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#621097}(cherry picked from commit 8fcb6ac127a39bcf86abcf0ff150fb4e72744a9d)
Reviewed-on: https://chromium-review.googlesource.com/c/1408868
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#657}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cc4279367430b7c2d8b85f13d02c024de9cd9d6

commit 5cc4279367430b7c2d8b85f13d02c024de9cd9d6
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Wed Jan 16 22:20:15 2019

[Password Generation] Fix metric about generated password changes in old parser

This CL is a verson of https://chromium-review.googlesource.com/c/chromium/src/+/1400810 for the old parser.

A generated password was considered changed even if a username or another field on a form was changed. Only password changes should be considred.

Bug: 883319
Change-Id: I9b22d6b05042e9116f4256af794599424296404c
Reviewed-on: https://chromium-review.googlesource.com/c/1414892
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623396}
[modify] https://crrev.com/5cc4279367430b7c2d8b85f13d02c024de9cd9d6/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/5cc4279367430b7c2d8b85f13d02c024de9cd9d6/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/5cc4279367430b7c2d8b85f13d02c024de9cd9d6/components/password_manager/core/browser/password_form_manager_unittest.cc

#13 is a copy of #12 for the old form parser. The team decided not to launch the new parser in M72 and the fix should be applied to the old parser. 

The fix adds one line to metrics collection logic. It affects only the metrics that we want to fix asap. 

This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Is the change verified in canary and safe to merge?

Yes, the change is in Canary 73.0.3674.0 since 01/17/19. The merge is safe. 

Approving merge to M72 branch 3626 based on comment #14 and #18. Please merge ASAP.

Also do we need to revert the merge listed at #12?

We don't need to revert #12. It is disabled by default.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8f4030771270031049129a48f279561e53f1f57

commit e8f4030771270031049129a48f279561e53f1f57
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Jan 18 07:10:51 2019

[Merge-72][Password Generation] Fix metric about generated password changes in old parser

This CL is a verson of https://chromium-review.googlesource.com/c/chromium/src/+/1400810 for the old parser.

A generated password was considered changed even if a username or another field on a form was changed. Only password changes should be considred.

Bug: 883319
Change-Id: I9b22d6b05042e9116f4256af794599424296404c
Reviewed-on: https://chromium-review.googlesource.com/c/1414892
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#623396}(cherry picked from commit 5cc4279367430b7c2d8b85f13d02c024de9cd9d6)
Reviewed-on: https://chromium-review.googlesource.com/c/1419902
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#723}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/e8f4030771270031049129a48f279561e53f1f57/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/e8f4030771270031049129a48f279561e53f1f57/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/e8f4030771270031049129a48f279561e53f1f57/components/password_manager/core/browser/password_form_manager_unittest.cc

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/e8f4030771270031049129a48f279561e53f1f57

Commit: e8f4030771270031049129a48f279561e53f1f57
Author: kolos@chromium.org
Commiter: kolos@chromium.org
Date: 2019-01-18 07:10:51 +0000 UTC

[Merge-72][Password Generation] Fix metric about generated password changes in old parser

This CL is a verson of https://chromium-review.googlesource.com/c/chromium/src/+/1400810 for the old parser.

A generated password was considered changed even if a username or another field on a form was changed. Only password changes should be considred.

Bug: 883319
Change-Id: I9b22d6b05042e9116f4256af794599424296404c
Reviewed-on: https://chromium-review.googlesource.com/c/1414892
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#623396}(cherry picked from commit 5cc4279367430b7c2d8b85f13d02c024de9cd9d6)
Reviewed-on: https://chromium-review.googlesource.com/c/1419902
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#723}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}