The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/838777d5d885ae3ec431945fdb097d40b6a33ca9

commit 838777d5d885ae3ec431945fdb097d40b6a33ca9
Author: Jialiu Lin <jialiul@chromium.org>
Date: Fri Oct 05 23:16:19 2018

Seed AccountTrackerService and SigninManager properly in Arc* tests

During the migration to IdentityManager, we noticed that some Arc*
related tests setup are incomplete, such that they will potentially fail
after IdentityManager migration.

This CL adds more initial test setup to seed AccountTrackerService and
SigninManager properly. No behavior or logic change.

Bug: 883318,  892116 
Change-Id: I4db443d7bd0c7df396e1c188743b869d2b9c2e82
Reviewed-on: https://chromium-review.googlesource.com/c/1265079
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597361}
[modify] https://crrev.com/838777d5d885ae3ec431945fdb097d40b6a33ca9/chrome/browser/chromeos/arc/arc_session_manager_browsertest.cc
[modify] https://crrev.com/838777d5d885ae3ec431945fdb097d40b6a33ca9/chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a36bf5fb9879bb398dd659f480d7968ba125c883

commit a36bf5fb9879bb398dd659f480d7968ba125c883
Author: Colin Blundell <blundell@chromium.org>
Date: Tue Dec 18 09:53:01 2018

Disallow new inclusions of SigninManager/ProfileOAuth2TokenService

Per https://groups.google.com/a/chromium.org/d/msg/chromium-dev/dgFLuxqZt1o/iEqkyoQQBwAJ,
prospective clients of these API surfaces should instead be using
IdentityManager. Contact identity-service-dev@ with any questions.

Where possible, inclusions are disallowed with "-". Where there are
existing usages that still need to be converted, inclusions are instead
disallowed with "!".

Note that the CQ will effectively not report any meaningful results for
this CL, as its usage of checkdeps doesn't run in directories where only
DEPS files have been changed. Here is the result of a local full run
of checkdeps.py:

blundell:src(forbid_new_inclusions) $  ./buildtools/checkdeps/checkdeps.py
Using base directory: /usr/local/google/home/blundell/clankium/src
Checking: /usr/local/google/home/blundell/clankium/src

SUCCESS

Finally, this CL also just strips out dependencies entirely that I
determined to be stale.

Bug: 883318, 883330
Change-Id: I3e9eb74497e18dbf437d5bfe1f4457b91574031f
Reviewed-on: https://chromium-review.googlesource.com/c/1374986
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617429}
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/chrome/browser/DEPS
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/chromeos/components/tether/DEPS
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/chromeos/services/device_sync/DEPS
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/components/autofill/core/browser/DEPS
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/components/browser_sync/DEPS
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/components/ntp_snippets/DEPS
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/components/password_manager/core/browser/DEPS
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/components/search_provider_logos/DEPS
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/components/suggestions/DEPS
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/components/sync/driver/DEPS
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/components/sync/user_events/DEPS
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/ios/chrome/browser/DEPS
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/ios/chrome/test/DEPS
[modify] https://crrev.com/a36bf5fb9879bb398dd659f480d7968ba125c883/ios/web_view/internal/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f4a6388719e185574a628756e7d4335a8a90a1d

commit 4f4a6388719e185574a628756e7d4335a8a90a1d
Author: Colin Blundell <blundell@chromium.org>
Date: Tue Dec 18 10:00:14 2018

Revert "Disallow new inclusions of SigninManager/ProfileOAuth2TokenService"

This reverts commit a36bf5fb9879bb398dd659f480d7968ba125c883.

Reason for revert: Whoops, just realized that a checkdeps failure got introduced in the last iteration, which will trigger on the waterfall. Proactively reverting and will make the small adjustment needed.

Original change's description:
> Disallow new inclusions of SigninManager/ProfileOAuth2TokenService
> 
> Per https://groups.google.com/a/chromium.org/d/msg/chromium-dev/dgFLuxqZt1o/iEqkyoQQBwAJ,
> prospective clients of these API surfaces should instead be using
> IdentityManager. Contact identity-service-dev@ with any questions.
> 
> Where possible, inclusions are disallowed with "-". Where there are
> existing usages that still need to be converted, inclusions are instead
> disallowed with "!".
> 
> Note that the CQ will effectively not report any meaningful results for
> this CL, as its usage of checkdeps doesn't run in directories where only
> DEPS files have been changed. Here is the result of a local full run
> of checkdeps.py:
> 
> blundell:src(forbid_new_inclusions) $  ./buildtools/checkdeps/checkdeps.py
> Using base directory: /usr/local/google/home/blundell/clankium/src
> Checking: /usr/local/google/home/blundell/clankium/src
> 
> SUCCESS
> 
> Finally, this CL also just strips out dependencies entirely that I
> determined to be stale.
> 
> Bug: 883318, 883330
> Change-Id: I3e9eb74497e18dbf437d5bfe1f4457b91574031f
> Reviewed-on: https://chromium-review.googlesource.com/c/1374986
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Commit-Queue: Colin Blundell <blundell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617429}

TBR=khorimoto@chromium.org,blundell@chromium.org,msarda@chromium.org,sdefresne@chromium.org,jochen@chromium.org

Change-Id: Ie6085179746cf06937c5506dc74ef4b5af0b6d75
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 883318, 883330
Reviewed-on: https://chromium-review.googlesource.com/c/1382074
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617431}
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/chrome/browser/DEPS
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/chromeos/components/tether/DEPS
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/chromeos/services/device_sync/DEPS
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/components/autofill/core/browser/DEPS
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/components/browser_sync/DEPS
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/components/ntp_snippets/DEPS
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/components/password_manager/core/browser/DEPS
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/components/search_provider_logos/DEPS
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/components/suggestions/DEPS
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/components/sync/driver/DEPS
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/components/sync/user_events/DEPS
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/ios/chrome/browser/DEPS
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/ios/chrome/test/DEPS
[modify] https://crrev.com/4f4a6388719e185574a628756e7d4335a8a90a1d/ios/web_view/internal/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d55fde86cc9f332843862dfa443742c9025c10a1

commit d55fde86cc9f332843862dfa443742c9025c10a1
Author: Colin Blundell <blundell@chromium.org>
Date: Tue Dec 18 16:04:37 2018

Disallow new inclusions of SigninManager/ProfileOAuth2TokenService

Per https://groups.google.com/a/chromium.org/d/msg/chromium-dev/dgFLuxqZt1o/iEqkyoQQBwAJ,
prospective clients of these API surfaces should instead be using
IdentityManager. Contact identity-service-dev@ with any questions.

Where possible, inclusions are disallowed with "-". Where there are
existing usages that still need to be converted, inclusions are instead
disallowed with "!".

Note that the CQ will effectively not report any meaningful results for
this CL, as its usage of checkdeps doesn't run in directories where only
DEPS files have been changed. Here is the result of a local full run
of checkdeps.py:

blundell:src(forbid_new_inclusions) $  ./buildtools/checkdeps/checkdeps.py
Using base directory: /usr/local/google/home/blundell/clankium/src
Checking: /usr/local/google/home/blundell/clankium/src

SUCCESS

Finally, this CL also just strips out dependencies entirely that I
determined to be stale.

This CL is a reland of https://chromium-review.googlesource.com/c/1374986
with a minor fix for a checkdeps error in PS2.

Note: Adding NOTRY=true as the only bot that's failing is the iOS
simulator bot, which is having timeout issues that are totally unrelated
to this CL.

TBR=msarda@chromium.org
NOTRY=true

Bug: 883318, 883330
Change-Id: I40971fdbfef00b4416ff7bfec875514706c0e26f
Reviewed-on: https://chromium-review.googlesource.com/c/1382092
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617509}
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/chrome/browser/DEPS
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/chromeos/components/tether/DEPS
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/chromeos/services/device_sync/DEPS
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/components/autofill/core/browser/DEPS
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/components/browser_sync/DEPS
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/components/ntp_snippets/DEPS
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/components/password_manager/core/browser/DEPS
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/components/search_provider_logos/DEPS
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/components/suggestions/DEPS
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/components/sync/driver/DEPS
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/components/sync/user_events/DEPS
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/ios/chrome/browser/DEPS
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/ios/chrome/test/DEPS
[modify] https://crrev.com/d55fde86cc9f332843862dfa443742c9025c10a1/ios/web_view/internal/DEPS