Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of ossu@chromium.org This causes webkit_unit_tests to fail on multiple builders Builders failed on: - Linux ChromiumOS MSan Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests - Linux MSan Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests
This seems to have been introduced in [1], PTAL! [1] https://chromium-review.googlesource.com/c/chromium/src/+/1194809
Example of error: ==9988==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x1a58125a in blink::WebEmbeddedWorkerImpl::StartWorkerThread() ./../../third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc:468:7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404 commit a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Wed Sep 12 16:46:34 2018 Revert "ServiceWorker: Implement ES modules for ServiceWorker scripts behind" This reverts commit 260d4608eb584984dd073c8a2a7d4dac2a0058f6. Reason for revert: Suspect that it is causing MSan failures, see https://crbug.com/883302 . Original change's description: > ServiceWorker: Implement ES modules for ServiceWorker scripts behind > the test-only flag > > This CL allows to import and evaluate as a module script at > ServiceWorker. Users can use it by adding type 'module' when > register a service worker script. > > As the first step, this CL implements ES Modules for new ServiceWorker > scripts. ES Modules for installed ServiceWorker scripts will be > implemented in separate CLs. Also, this doesn't implement dynamic > import yet. This feature is enabled by the test-only flag in this CL. > > i.e. > // index.html > const registration = await navigator.serviceWorker.register( > "service_worker.js", > { type: "module" }); > > Spec: https://w3c.github.io/ServiceWorker/#serviceworkercontainer-interface > > Bug: 824647 > Change-Id: I023c7ca881a90327730011699a8db879653cafdf > Reviewed-on: https://chromium-review.googlesource.com/1194809 > Commit-Queue: Asami Doi <asamidoi@google.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590628} TBR=falken@chromium.org,kinuko@chromium.org,kouhei@chromium.org,nhiroki@chromium.org,asamidoi@google.com Change-Id: I33d0220d687716e7a63c84170a3a6bafa97cc988 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824647, 883302 Reviewed-on: https://chromium-review.googlesource.com/1221704 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#590719} [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/chrome/browser/chrome_service_worker_browsertest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/browsing_data/clear_site_data_handler_browsertest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/embedded_worker_instance_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_browsertest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_context_request_handler_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_context_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_context_wrapper.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_installed_scripts_sender_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_job_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_navigation_loader_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_new_script_loader_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_object_host_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_provider_host_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_register_job.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_register_job.h [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_registration_object_host.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_registration_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_script_loader_factory_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_storage.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_storage_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_url_request_job_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_version.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_version.h [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_version_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_write_to_cache_job.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_write_to_cache_job.h [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/common/service_worker/embedded_worker.mojom [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/renderer/service_worker/embedded_worker_instance_client_impl.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/renderer/service_worker/service_worker_context_client_unittest.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/renderer/service_worker/web_service_worker_provider_impl.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/content/renderer/service_worker/web_service_worker_provider_impl.h [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/third_party/blink/public/mojom/service_worker/service_worker_registration.mojom [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/third_party/blink/public/platform/modules/service_worker/web_service_worker_provider.h [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/third_party/blink/public/web/web_embedded_worker_start_data.h [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/third_party/blink/renderer/core/loader/resource/script_resource.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/third_party/blink/renderer/core/script/script.h [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/third_party/blink/renderer/core/workers/global_scope_creation_params.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/third_party/blink/renderer/core/workers/global_scope_creation_params.h [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/third_party/blink/renderer/core/workers/worker_module_tree_client.h [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/third_party/blink/renderer/modules/service_worker/registration_options.idl [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/third_party/blink/renderer/modules/service_worker/service_worker_container.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/third_party/blink/renderer/modules/service_worker/service_worker_container_test.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc [modify] https://crrev.com/a7dd3bd6af99ee62527148d9dfdb9eef8ef2c404/third_party/blink/renderer/platform/runtime_enabled_features.json5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5de8dea8a28da23d0b0d528948c68453ece26a35 commit 5de8dea8a28da23d0b0d528948c68453ece26a35 Author: Asami Doi <asamidoi@google.com> Date: Thu Sep 13 10:01:07 2018 Reland "ServiceWorker: Implement ES modules for ServiceWorker scripts behind the test-only flag" This is a reland of 260d4608eb584984dd073c8a2a7d4dac2a0058f6. 1194809 was reverted because it was causing MSan failures by accessing an uninitialized field in WebEmbeddedWorkerImplTest. This CL fixes it. See https://crbug.com/883302 . Original change's description: > ServiceWorker: Implement ES modules for ServiceWorker scripts behind > the test-only flag > > This CL allows to import and evaluate as a module script at > ServiceWorker. Users can use it by adding type 'module' when > register a service worker script. > > As the first step, this CL implements ES Modules for new ServiceWorker > scripts. ES Modules for installed ServiceWorker scripts will be > implemented in separate CLs. Also, this doesn't implement dynamic > import yet. This feature is enabled by the test-only flag in this CL. > > i.e. > // index.html > const registration = await navigator.serviceWorker.register( > "service_worker.js", > { type: "module" }); > > Spec: https://w3c.github.io/ServiceWorker/#serviceworkercontainer-interface > > Bug: 824647 > Change-Id: I023c7ca881a90327730011699a8db879653cafdf > Reviewed-on: https://chromium-review.googlesource.com/1194809 > Commit-Queue: Asami Doi <asamidoi@google.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#590628} Bug: 824647, 883302 Change-Id: I160a2d88514ceb6733e9b49758cb3efc2d22c5de TBR: falken@chromium.org,kinuko@chromium.org,kouhei@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1222027 Commit-Queue: Asami Doi <asamidoi@google.com> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#590962} [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/chrome/browser/chrome_service_worker_browsertest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/browsing_data/clear_site_data_handler_browsertest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/embedded_worker_instance_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_browsertest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_context_request_handler_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_context_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_context_wrapper.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_dispatcher_host_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_installed_scripts_sender_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_job_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_navigation_loader_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_new_script_loader_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_object_host_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_provider_host_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_read_from_cache_job_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_register_job.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_register_job.h [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_registration_object_host.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_registration_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_script_loader_factory_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_storage.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_storage_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_url_request_job_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_version.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_version.h [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_version_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_write_to_cache_job.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_write_to_cache_job.h [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/common/service_worker/embedded_worker.mojom [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/renderer/service_worker/embedded_worker_instance_client_impl.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/renderer/service_worker/service_worker_context_client_unittest.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/renderer/service_worker/web_service_worker_provider_impl.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/content/renderer/service_worker/web_service_worker_provider_impl.h [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/third_party/blink/public/mojom/service_worker/service_worker_registration.mojom [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/third_party/blink/public/platform/modules/service_worker/web_service_worker_provider.h [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/third_party/blink/public/web/web_embedded_worker_start_data.h [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/third_party/blink/renderer/core/loader/resource/script_resource.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/third_party/blink/renderer/core/script/script.h [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/third_party/blink/renderer/core/workers/global_scope_creation_params.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/third_party/blink/renderer/core/workers/global_scope_creation_params.h [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/third_party/blink/renderer/core/workers/worker_module_tree_client.h [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/third_party/blink/renderer/modules/service_worker/registration_options.idl [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/third_party/blink/renderer/modules/service_worker/service_worker_container.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/third_party/blink/renderer/modules/service_worker/service_worker_container_test.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/third_party/blink/renderer/modules/service_worker/web_embedded_worker_impl_test.cc [modify] https://crrev.com/5de8dea8a28da23d0b0d528948c68453ece26a35/third_party/blink/renderer/platform/runtime_enabled_features.json5
Comment 1 by ossu@chromium.org
, Sep 12Status: Assigned (was: Available)