New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 883301 link

Starred by 1 user
Status: Fixed
Owner:
pkotw...@chromium.org
Closed: Oct 3
Cc:
█ mtragut@google.com
hanxi@chromium.org
█ hzjian@chromium.org
hartma...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Update WebApk shell code to target P sdk

Project Member Reported by yfried...@chromium.org, Sep 12 
Now that P is out, we need to move webapks to target the latest SDK.
Compatibility notes here: https://developer.android.com/about/versions/pie/android-9.0-changes-28

More info here: b/113564410
cc: mtragut as Maps will need to re-spin at some point once it's ready

Note that b/113905347 is probably blocking a new release of maps
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b3a3db64270aae46f3e68a1676217dc469c2d95

commit 9b3a3db64270aae46f3e68a1676217dc469c2d95
Author: Peter Kotwicz <pkotwicz@chromium.org>
Date: Wed Oct 03 01:06:01 2018

[Android WebAPK] Set targetSdkVersion to Android P for WebAPKs

BUG= 883301 

Change-Id: I846477189f74726f2f3c2cc0f2f7ac78964fd48c
Reviewed-on: https://chromium-review.googlesource.com/c/1256003
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596079}
[modify] https://crrev.com/9b3a3db64270aae46f3e68a1676217dc469c2d95/chrome/android/webapk/shell_apk/AndroidManifest.xml
[modify] https://crrev.com/9b3a3db64270aae46f3e68a1676217dc469c2d95/chrome/android/webapk/shell_apk/current_version/current_version.gni

Comment 2 by pkotw...@chromium.org, Oct 3

Status: Fixed (was: Assigned)
►

Sign in to add a comment