New issue
Advanced search Search tips

Issue 883294 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 723233



Sign in to add a comment

extreme use of logging.info for `Active resource loading` in our webapp

Reported by bramvera...@gmail.com, Sep 12

Issue description

Chrome Version       : 69.0.3497.92
URLs (if applicable) : not applicable
Other browsers tested: yes
  Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:
     Safari: NO
    Firefox: YES, no extreme console logging
       Edge: NO

What steps will reproduce the problem?
(1) Use of our private inhouse webapplication

What is the expected result?
no extreme console.logs spamming of : Active resource loading counts reached to a per-frame limit while the tab is in background. Network requests will be delayed until a previous loading finishes, or the tab is foregrounded

What happens instead?
personal debugging information in the console gets lost in chrome loggings

Please provide any additional information below. Attach a screenshot if
possible.

 
chrome_spam.png
177 KB View Download
Labels: Needs-Triage-M69
Owner: toyoshim@chromium.org
Status: Assigned (was: Unconfirmed)
Thank you for feedback.

It looks 'Group similar' feature in the console is not enough to avoid the so many logs issue if developer needs to show own logs.

For a tentative solution, you can filter out info level messages in the console. But for a permanent solution, I should I should make it appear once during the frame active/inactive state is not changed.
thx, once every active/inactive state is a way better soluton in my mind. 
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3e236b01c92a5a334c818454bbf6bdb7377e615

commit e3e236b01c92a5a334c818454bbf6bdb7377e615
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Fri Sep 14 08:07:01 2018

ResourceLoadScheduler: Omit console info until the next state change

Currently, we show console info when a throttling happens. I expect
console's feature to gather similar messages omits repeating messages.
But it does not work well if users' JavaScript put own logs.

This patch adds a boolean flag to omit repeating messages. The flag
will be reset when SchedulingLifecycleState changes. This should not
happen so frequently.

Bug:  883294 
Change-Id: I3e7844a7d4456fde88e198f500e21cb74c2ada64
Reviewed-on: https://chromium-review.googlesource.com/1226482
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591299}
[modify] https://crrev.com/e3e236b01c92a5a334c818454bbf6bdb7377e615/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
[modify] https://crrev.com/e3e236b01c92a5a334c818454bbf6bdb7377e615/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.h

Labels: Target-71
Status: Fixed (was: Assigned)
Fixed for m71.

Sign in to add a comment