New issue
Advanced search Search tips

Issue 883282 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 712341
Owner:
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to remove bookmark using keyboard(Space key or Enter Key).

Reported by aiman.an...@etouch.net, Sep 12

Issue description

Chrome Version: 70.0.3538.16 (Official Build) Revision16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306} (32/64-bit).

OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTs).

What steps will reproduce the problem?
1. Launch Chrome, open NTP and bookmark NTP.
2. Hit Tab once(focus will reach on Avatar icon), then HIT Shift+Tab (to again bring focus on Star bookmark icon).
3. Press Space-Key to open bookmark overlay.
4. Press TAB key until focus reaches Remove button and again HIT Space-Key or Enter key.
5. Observe.

Actual: Unable to remove bookmark using keyboard(Space key or Enter Key).
Expected: Should be able to remove bookmark using Keyboard  keys.

This is a regression issue, broken in M-70 series, below is manual regression range.

Good build: 70.0.3503.0 (Revision:578160)
Bad build: 70.0.3504.0 (Revision:578510)

You are probably looking for a change made after 578333 (known good), but no later than 578334 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/bcb7db78edc13f57577f0a9562c98918bdcc10ae..67d21d10815fe6d87d1785a65a50fbc386e6605b

Suspecting: https://chromium.googlesource.com/chromium/src/+/67d21d10815fe6d87d1785a65a50fbc386e6605b

@ellyjones: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: This issue is also reproducible on Canary #71.0.3550.0

Kindly review the attached screen-cast for reference.

Thank you.

 
Actual Result.mov
1.9 MB View Download
Expected Result.mov
1.5 MB View Download
Cc: pbomm...@chromium.org
Labels: ReleaseBlock-Stable
marking as RBS, please change if required.
Cc: lgrey@chromium.org
This is caused by the keydown triggering the "Remove" button press and then the keyup being handled by the keyboard-focused bookmark star behind it. This has been a longstanding bug - I'll try to get a fix into M70.

cc lgrey@ who I think has some context here.
This is definitely ringing a bell (maybe something about the password bubble closing itself prematurely and then reopening?), but not very clearly.
Mergedinto: 712341
Status: Duplicate (was: Assigned)
Found it:  issue 712341 

Sign in to add a comment