Use metrics to improve AccountTrackerService |
||
Issue descriptionMetrics were recently added to AccountTrackerService to measure: 1. whether the deprecated service flags have been deleted, 2. whether the migration of the account_id to gaia_id has completed, 3. count the number of accounts loaded from preferences. Results from the first two histograms should help decide whether corresponding migration code is dead and can be removed or not. Results from the last histograms should help inform whether it is possible to refactor the code to use better data structure than std::map<std::string, AccountState> (if # of account is consistently small, linear search in a std::vector<> may be good enough). Metrics will appear in M-71, so setting next action at beginning of 2019.
,
Jan 10
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b54ffff34e4c4be64274ba4a35501e4a5dd60372 commit b54ffff34e4c4be64274ba4a35501e4a5dd60372 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Jan 10 16:56:37 2019 Stop exposing kChildAccountServiceFlag The constant exposed by AccountTrackerService is tied to a preference that is marked for deletion with a TODO(M48) thus likely ripe to be removed. As a first step, move the constant to the implementation file. Bug: 883272 Change-Id: I72a22ea874899bcebbaf9991096086ef4a6809cf Reviewed-on: https://chromium-review.googlesource.com/c/1404173 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#621610} [modify] https://crrev.com/b54ffff34e4c4be64274ba4a35501e4a5dd60372/components/signin/core/browser/account_tracker_service.cc [modify] https://crrev.com/b54ffff34e4c4be64274ba4a35501e4a5dd60372/components/signin/core/browser/account_tracker_service.h |
||
►
Sign in to add a comment |
||
Comment 1 by monor...@bugs.chromium.org
, Jan 1