AEC3: Bad transparency at low echo levels |
||
Issue descriptionAEC3 could improve its transparency in scenarios with low powered echoes: - The main filter diverges during simultaneous nearend and low echoes. - Too frequent switching between the main and shadow filters cause audible artifacts.
,
Sep 12
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/958ed238603ba5a2937d28ce1c9281920d923019 commit 958ed238603ba5a2937d28ce1c9281920d923019 Author: Gustaf Ullberg <gustaf@webrtc.org> Date: Wed Sep 12 14:09:00 2018 AEC3: Reduce filter divergence during low-echo double-talk Bug: webrtc:9746 , chromium:883264 Change-Id: Ie3faf106fd1fd835e67d9e6794c679703af54fea Reviewed-on: https://webrtc-review.googlesource.com/99920 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24706} [modify] https://crrev.com/958ed238603ba5a2937d28ce1c9281920d923019/api/audio/echo_canceller3_config.h
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b4888ecbb0c29135c87a6b562587f6bc44cd747 commit 2b4888ecbb0c29135c87a6b562587f6bc44cd747 Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Sep 12 18:39:51 2018 Roll src/third_party/webrtc 640106e1ce35..afc3eb1a7347 (11 commits) https://webrtc.googlesource.com/src.git/+log/640106e1ce35..afc3eb1a7347 git log 640106e1ce35..afc3eb1a7347 --date=short --no-merges --format='%ad %ae %s' 2018-09-12 danilchap@webrtc.org in test::FrameGeneratorCapturer try to keep up with fps when overloaded 2018-09-12 buildbot@webrtc.org Roll chromium_revision bd99b7d4a8..c07e991426 (590554:590658) 2018-09-12 jonasolsson@webrtc.org Add support for logging absl::string_view. 2018-09-12 gustaf@webrtc.org AEC3: Reduce filter divergence during low-echo double-talk 2018-09-12 nisse@webrtc.org Make the rtp timestamp member of EncodedImage private 2018-09-12 sakal@webrtc.org Place static objects into a container that gets leaked. 2018-09-12 minyue@webrtc.org Avoid wrong parsing of padding length and its use in NetEq simulation. 2018-09-12 danilchap@webrtc.org Cleanup RtpPacketizerH264 constructor 2018-09-12 ssilkin@webrtc.org Revert "Add SSLConfig object to IceServer." 2018-09-12 josea.olivera@gmail.com Remove unused var in device info bits from video capture module for Linux 2018-09-12 ilnik@webrtc.org Move variance calculation in SampleCounter to a new extension class Created with: gclient setdep -r src/third_party/webrtc@afc3eb1a7347 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:883264,chromium:b/113648474,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia830905358e6a25dd14063745fe9c70adc846dcc Reviewed-on: https://chromium-review.googlesource.com/1221703 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590762} [modify] https://crrev.com/2b4888ecbb0c29135c87a6b562587f6bc44cd747/DEPS
,
Sep 14
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/b55df9259fd19c6a17652f17f8d2e6085682475e commit b55df9259fd19c6a17652f17f8d2e6085682475e Author: Gustaf Ullberg <gustaf@webrtc.org> Date: Fri Sep 14 13:41:44 2018 Revert "AEC3: Reduce filter divergence during low-echo double-talk" This reverts commit 958ed238603ba5a2937d28ce1c9281920d923019. Reason for revert: Will need additional work to handle clock-drift. Original change's description: > AEC3: Reduce filter divergence during low-echo double-talk > > Bug: webrtc:9746 , chromium:883264 > Change-Id: Ie3faf106fd1fd835e67d9e6794c679703af54fea > Reviewed-on: https://webrtc-review.googlesource.com/99920 > Reviewed-by: Per Åhgren <peah@webrtc.org> > Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#24706} TBR=gustaf@webrtc.org,peah@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:9746 , chromium:883264 Change-Id: Ib039eb80e2ddfc43ec52183086da2474baef65e0 Reviewed-on: https://webrtc-review.googlesource.com/100480 Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24741} [modify] https://crrev.com/b55df9259fd19c6a17652f17f8d2e6085682475e/api/audio/echo_canceller3_config.h
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4178c9f0ec6343e965df96194bd03e7924105da4 commit 4178c9f0ec6343e965df96194bd03e7924105da4 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Sep 14 17:16:06 2018 Roll src/third_party/webrtc af6c139eb6ff..c7d935899ab9 (3 commits) https://webrtc.googlesource.com/src.git/+log/af6c139eb6ff..c7d935899ab9 git log af6c139eb6ff..c7d935899ab9 --date=short --no-merges --format='%ad %ae %s' 2018-09-14 henrika@webrtc.org Adds multi-channel support to new ADM2 on Windows. 2018-09-14 peah@webrtc.org audioproc_f: Modified and added further logging of used aec3 parameters 2018-09-14 gustaf@webrtc.org Revert "AEC3: Reduce filter divergence during low-echo double-talk" Created with: gclient setdep -r src/third_party/webrtc@c7d935899ab9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG= chromium:883264 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia9d7c190ab9176cf8b0c9a8c7f8d7a07df780b06 Reviewed-on: https://chromium-review.googlesource.com/1226382 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591380} [modify] https://crrev.com/4178c9f0ec6343e965df96194bd03e7924105da4/DEPS
,
Oct 9
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/040f87f934f5e1d2ecd12436b984479e3c2dac71 commit 040f87f934f5e1d2ecd12436b984479e3c2dac71 Author: Gustaf Ullberg <gustaf@webrtc.org> Date: Tue Oct 09 14:09:26 2018 AEC3: Allow a more stable filter during double-talk This is a new attempt to reduce the filter divergence during double-talk without regressing in clock-drift scenarios. - The error_floor in decreased to allow for slow adaptation when the filter performs well. - The leakage_diverged is increased to allow for fast adaptation when the shadow filter performs better. - A new parameter, error_ceil, was added to stop the filter from adapting too fast. Bug: webrtc:9746 , chromium:883264 Change-Id: Ie2868d2388b48412a192a004ec13f9eff34517b8 Reviewed-on: https://webrtc-review.googlesource.com/c/100460 Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25063} [modify] https://crrev.com/040f87f934f5e1d2ecd12436b984479e3c2dac71/api/audio/echo_canceller3_config.h [modify] https://crrev.com/040f87f934f5e1d2ecd12436b984479e3c2dac71/modules/audio_processing/aec3/echo_canceller3.cc [modify] https://crrev.com/040f87f934f5e1d2ecd12436b984479e3c2dac71/modules/audio_processing/aec3/main_filter_update_gain.cc [modify] https://crrev.com/040f87f934f5e1d2ecd12436b984479e3c2dac71/modules/audio_processing/test/audio_processing_simulator.cc
,
Oct 9
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fce8abb56661ab821d01f22290e1bd51c0591bc2 commit fce8abb56661ab821d01f22290e1bd51c0591bc2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Oct 09 18:20:51 2018 Roll src/third_party/webrtc 70045719ab93..040f87f934f5 (2 commits) https://webrtc.googlesource.com/src.git/+log/70045719ab93..040f87f934f5 git log 70045719ab93..040f87f934f5 --date=short --no-merges --format='%ad %ae %s' 2018-10-09 gustaf@webrtc.org AEC3: Allow a more stable filter during double-talk 2018-10-09 phoglund@webrtc.org Remove SetExecutablePath, simplify ResourcePath Created with: gclient setdep -r src/third_party/webrtc@040f87f934f5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG= chromium:883264 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iede3ec086e6bb3220578226511ec96c135f2117e Reviewed-on: https://chromium-review.googlesource.com/c/1269950 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597998} [modify] https://crrev.com/fce8abb56661ab821d01f22290e1bd51c0591bc2/DEPS |
||
►
Sign in to add a comment |
||
Comment 1 by gustaf@chromium.org
, Sep 12