New issue
Advanced search Search tips

Issue 883262 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

viz_browser_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Sep 12

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of ossu@chromium.org

viz_browser_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Builders failed on: 
- Linux Chromium OS ASan LSan Tests (1): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29


 
Components: Blink>USB
Owner: donna...@intel.com
Status: Assigned (was: Available)
Looks like the change in https://chromium-review.googlesource.com/c/chromium/src/+/1210386 may have introduced some test failures. PTAL!
This is also erroring out in WebUsbTest.AddRemoveDeviceEphemeral on the win-asan bot:
[ RUN      ] WebUsbTest.AddRemoveDeviceEphemeral
[8412:9160:0912/035735.940:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[8412:6896:0912/035736.084:WARNING:chrome_browser_main_win.cc(642)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=WebUsbTest.AddRemoveDeviceEphemeral --no-sandbox --single_process --test-launcher-bot-mode --test-launcher-filter-file=../../testing/buildbot/filters/mojo.fyi.network_browser_tests.filter --test-launcher-output="C:\b\s\w\itoxxo0w\scoped_dir5744_8716\results5744_13216\test_results.xml" --test-launcher-summary-output="C:\b\s\w\iog9yprz\output.json" --user-data-dir="C:\b\s\w\itoxxo0w\scoped_dir5744_8716\d5744_21835" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --browser-test --ipc-connection-timeout=90 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=NetworkService,TestFeatureForBrowserTest1 --disable-features=TestFeatureForBrowserTest2 --disable-gpu-process-for-dx12-vulkan-info-collection --flag-switches-begin --flag-switches-end --file-url-path-alias="/gen=C:\b\s\w\ir\out\Release_x64\gen" --restore-last-session about:blank
[8412:9084:0912/035738.299:WARNING:embedded_test_server.cc(238)] Request not handled. Returning 404: /favicon.ico
../../chrome/browser/usb/usb_browsertest.cc(322): error: Expected equality of these values:
  ""
  result
    Which is: "null"
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/171eed0b622e3252b8abe703a70b8d283267125d

commit 171eed0b622e3252b8abe703a70b8d283267125d
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Wed Sep 12 16:51:11 2018

Revert "Listen to UsbDeviceManager instead of UsbService in UsbChooserContext."

This reverts commit a0f301ad19908c1320f0b00d87f0469b6009b5a6.

Reason for revert: Suspect that is causes test failures in Linux ASan, see  https://crbug.com/883262 .

Original change's description:
> Listen to UsbDeviceManager instead of UsbService in UsbChooserContext.
> 
> For UsbService::Observer, "OnDeviceRemovedCleanup" needs to be handled
> after "OnDeviceRemoved". But for mojom interface UsbDeviceManager,
> there is no way to provide such dependency among listeners.
> 
> As all users will be converted from UsbService to UsbDeviceManager,
> to avoid the potential race condition, WebUsbServiceImpl is made
> listen to UsbChooserContext in this CL.
> 
> Bug: 699790
> Change-Id: I1e3b45196552e987b7422b127651e1fb01e1618b
> Reviewed-on: https://chromium-review.googlesource.com/1210386
> Commit-Queue: Donna Wu <donna.wu@intel.com>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590609}

TBR=reillyg@chromium.org,donna.wu@intel.com

Change-Id: I954dd50c4cf8b5b761ede371f8ff904c07a61993
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 699790,  883262 
Reviewed-on: https://chromium-review.googlesource.com/1222107
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590720}
[modify] https://crrev.com/171eed0b622e3252b8abe703a70b8d283267125d/chrome/browser/usb/usb_browsertest.cc
[modify] https://crrev.com/171eed0b622e3252b8abe703a70b8d283267125d/chrome/browser/usb/usb_chooser_context.cc
[modify] https://crrev.com/171eed0b622e3252b8abe703a70b8d283267125d/chrome/browser/usb/usb_chooser_context.h
[modify] https://crrev.com/171eed0b622e3252b8abe703a70b8d283267125d/chrome/browser/usb/usb_chooser_context_unittest.cc
[modify] https://crrev.com/171eed0b622e3252b8abe703a70b8d283267125d/chrome/browser/usb/usb_chooser_controller.cc
[modify] https://crrev.com/171eed0b622e3252b8abe703a70b8d283267125d/chrome/browser/usb/web_usb_service_impl.cc
[modify] https://crrev.com/171eed0b622e3252b8abe703a70b8d283267125d/chrome/browser/usb/web_usb_service_impl.h
[modify] https://crrev.com/171eed0b622e3252b8abe703a70b8d283267125d/chrome/browser/usb/web_usb_service_impl_unittest.cc
[modify] https://crrev.com/171eed0b622e3252b8abe703a70b8d283267125d/device/usb/mojo/device_manager_impl.cc
[modify] https://crrev.com/171eed0b622e3252b8abe703a70b8d283267125d/device/usb/mojo/device_manager_impl.h
[modify] https://crrev.com/171eed0b622e3252b8abe703a70b8d283267125d/device/usb/mojo/device_manager_impl_unittest.cc

Labels: Type-Bug
 Issue 883688  has been merged into this issue.
Cc: stale-flakes-reports@google.com
Reporting to stale-flakes-reports@google.com to investigate why this issue is not being processed despite being in an appropriate queue for 7 days or more.
Labels: -Sheriff-Chromium
Status: Fixed (was: Assigned)
The patch triggering this crash has been reverted and a fixed version landed without issue.

Sign in to add a comment