New issue
Advanced search Search tips

Issue 883229 link

Starred by 1 user
Status: Fixed
Owner:
joelhockey@chromium.org
Closed: Sep 17
Cc:
lucmult@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Rename/shorten fileManagerPrivate.mountCrostiniContainer and sharePathWithCrostiniContainer remove 'Container'

Project Member Reported by joelhockey@chromium.org, Sep 12 
Rename / shorten some crostini FilesApp function names.

mountCrostiniContainer -> mountCrostini
sharePathWithCrostiniContainer -> sharePathWithCrostini

A new getPathsSharedWithCrostiniContainer function was getting a bit too long, so it was changed to getCrostiniSharedPaths.

Update other functions to stay consistent.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5529d278a51ec22679aeebbcd4d9489b8d320861

commit 5529d278a51ec22679aeebbcd4d9489b8d320861
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Sep 13 01:53:18 2018

FilesApp rename/shorten *CrostiniContainer functions to *Crostini

This is a rename only CL.  No change to functionality.

Rename:
mountCrostiniContainer => mountCrostini
sharePathWithCrostiniContainer => sharePathWithCrostini

Function names in extension_function_histogram_value.h have been
renamed, but purposely keep the existing IDs so existing counts
will remain.

Bug:  883229 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I5e90ef993532c989970102971345265edee6f8f6
Reviewed-on: https://chromium-review.googlesource.com/1221426
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590891}
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/chrome/browser/chromeos/extensions/file_manager/private_api_misc.h
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/chrome/common/extensions/api/file_manager_private_internal.idl
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/chrome/renderer/resources/extensions/file_manager_private_custom_bindings.js
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/chrome/test/data/extensions/api_test/file_browser/crostini_test/manifest.json
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/chrome/test/data/extensions/api_test/file_browser/crostini_test/test.js
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/third_party/closure_compiler/externs/file_manager_private.js
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/ui/file_manager/file_manager/foreground/js/directory_contents.js
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/ui/file_manager/file_manager/test/crostini.js
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/ui/file_manager/file_manager/test/js/chrome_file_manager_private_test_impl.js
[modify] https://crrev.com/5529d278a51ec22679aeebbcd4d9489b8d320861/ui/file_manager/integration_tests/file_manager/crostini.js

Comment 2 by joelhockey@chromium.org, Sep 17

Status: Fixed (was: Assigned)
►

Sign in to add a comment