Regression: Overlapping of buttons is seen on chrome background overlay after changing font size.
Reported by
pranjali...@etouch.net,
Sep 12
|
||||||
Issue descriptionChrome version :70.0.3538.16 (Official Build) 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}(32/64 bit) OS: Win(7,8,8.1,10) , Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) and Linux(14.04 LTS) OS Precondition: Enable the flag 'Enable using the Google local NTP' and 'New Tab Page Background Selection' from chrome://flags/ What steps will reproduce the problem? 1.Launch chrome and navigate to 'chrome://settings/fonts'. 2.Change both 'Font size' and 'Minimum Font Size' to huge. 3.open NTP and click on 'Gear' icon. 4.Click on 'chrome backgrounds' option and observe. Actual : Overlapping of buttons is seen on chrome background overlay after changing font size to huge. Expected: Overlapping of buttons should not be seen on chrome background overlay after changing font size to huge. This is a regression issue broken in ‘M-70’ and below is bisect info. Good build: 70.0.3522.0 Bad build: 70.0.3523.0 You are probably looking for a change made after 582819 (known good), but no later than 582820 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/de901269bda0d336f0777e6df373756ff04451d4..ed0680928e4c6937f513a7efa0652c1dd6a18a98 Suspect: https://chromium.googlesource.com/chromium/src/+/ed0680928e4c6937f513a7efa0652c1dd6a18a98 @sweilun: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank You
,
Sep 13
,
Sep 13
,
Sep 13
It might make sense to look at issue 879502 at the same time.
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22a0eea6449d2045c5daedb3f8d1ce24467977c0 commit 22a0eea6449d2045c5daedb3f8d1ce24467977c0 Author: Weilun Shi <sweilun@chromium.org> Date: Fri Sep 14 01:20:21 2018 [NTP] Change position setting for buttons on custom background dialog Change position setting to relative and add margin to make sure they keep the same as what they look like. But the change will make sure the space between buttons will always be the same to avoid overlapping issue. LTR Screencast: https://screencast.googleplex.com/cast/NjI0NTA4NTM4OTc4MzA0MHwwOGJhMjBjMS1lNQ RTL Screencast: https://screencast.googleplex.com/cast/NDgzNzcxMDUwNjIyOTc2MHxlODQ5ZjRmZS03Zg Bug: 883202 Change-Id: Id3073276c819e47dd61bbe92550b520c087f447d Reviewed-on: https://chromium-review.googlesource.com/1226451 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#591252} [modify] https://crrev.com/22a0eea6449d2045c5daedb3f8d1ce24467977c0/chrome/browser/resources/local_ntp/custom_backgrounds.css
,
Sep 14
,
Sep 17
Update : Rechecked the above issue on Win(7,8,8.1,10) , Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) and Linux(14.04 LTS) OS with latest Canary Chrome version : 71.0.3554.0 and the issue is Fixed.Hence adding TE Verified Labels. Kindly refer the attached screen cast for reference. Thank you..!!
,
Nov 9
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sweilun@chromium.org
, Sep 13