Buttons on 'Add Shortcut' overlay are not properly aligned on NTP.
Reported by
sanyam.g...@etouch.net,
Sep 12
|
||||||
Issue descriptionChrome Version: 70.0.3538.16 (Official Build)Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}(32/64-bit) OS: Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) & Linux(14.04 LTS) OS. Pre-condition: Enable 'Enable using the Google local NTP' and 'New Tab Page Custom Links' under chrome://flags. What steps will reproduce the problem? 1. Launch Chrome, navigate to 'chrome://settings/fonts'. 2. Increase 'Font Size' and 'Minimum font size' to huge. 3. Navigate to NTP, click on 'Add Shortcut' to open the overlay and observe. Actual Result : Buttons on 'Add Shortcut' overlay are not properly aligned. Expected Result: Buttons on 'Add Shortcut' overlay should be properly aligned. This is Non-Regression issue seen from ‘M-70’ as 'Add shortcut' option has been introduced from build #70.0.3504.0 Kindly review the attached screen-cast for reference. Thank you..!!
,
Sep 18
,
Oct 1
Taking this since is a quick fix.
,
Oct 1
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e89bb96984c26e449604fca216435e0f7b10afa6 commit e89bb96984c26e449604fca216435e0f7b10afa6 Author: Weilun Shi <sweilun@chromium.org> Date: Tue Oct 02 01:02:24 2018 [NTP] Adding a left span for custom links edit html When changing the font size on the settings, changing on the remove button is different than changing on the right span container for the other two buttons, that's why we see the inconsistent behavior. Therefore, adding additional left span for the remove button. Screencast: https://screencast.googleplex.com/cast/NDkxMzQ4OTQ4NzMzMTMyOHw5N2Y4MzQzMS0yYQ Bug: 883192 Change-Id: I398402cfdec9d8a93e95802fb4d99f6ded552cd0 Reviewed-on: https://chromium-review.googlesource.com/1255612 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#595670} [modify] https://crrev.com/e89bb96984c26e449604fca216435e0f7b10afa6/chrome/browser/resources/local_ntp/custom_links_edit.css [modify] https://crrev.com/e89bb96984c26e449604fca216435e0f7b10afa6/chrome/browser/resources/local_ntp/custom_links_edit.html
,
Oct 2
,
Oct 3
Update : Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) OS with Canary version #71.0.3569.0 and the issue is fixed. Kindly refer the attached screen cast. Thank You..!! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ramyan@chromium.org
, Sep 12Owner: kristip...@chromium.org