New issue
Advanced search Search tips

Issue 883191 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[πŸ“] Allow /api/new users to specify a quest list.

Project Member Reported by dtu@chromium.org, Sep 12

Issue description

Right now, we infer the quest list from the target, which is a little hacky. `target` is an argument for the FindIsolate quest, not a Job argument.

If a user wants to do a compile bisect or run custom quests, they need to be able to specify what quests to run.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/d64f0324b3984c26c798bc6953234f99a20b145f

commit d64f0324b3984c26c798bc6953234f99a20b145f
Author: Dave Tu <dtu@chromium.org>
Date: Wed Sep 12 17:01:28 2018

[pinpoint] Allow /api/new users to specify a quest list.

Bug:  chromium:883191 
Change-Id: I2c2a2d5419d088058b4b11f8654c69e3bb4ffdb6
Reviewed-on: https://chromium-review.googlesource.com/1220891
Reviewed-by: Juan Antonio Navarro PΓ©rez <perezju@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Commit-Queue: Dave Tu <dtu@chromium.org>

[modify] https://crrev.com/d64f0324b3984c26c798bc6953234f99a20b145f/dashboard/dashboard/pinpoint/handlers/new_test.py
[modify] https://crrev.com/d64f0324b3984c26c798bc6953234f99a20b145f/dashboard/dashboard/pinpoint/handlers/new.py

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a5bebd60330cb4b99c6a07d915398d7a04359d2

commit 2a5bebd60330cb4b99c6a07d915398d7a04359d2
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Sep 12 18:55:56 2018

Roll src/third_party/catapult 79834ec727ba..d64f0324b398 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/79834ec727ba..d64f0324b398


git log 79834ec727ba..d64f0324b398 --date=short --no-merges --format='%ad %ae %s'
2018-09-12 dtu@chromium.org [pinpoint] Allow /api/new users to specify a quest list.


Created with:
  gclient setdep -r src/third_party/catapult@d64f0324b398

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:883191 
TBR=sullivan@chromium.org

Change-Id: I3886f9f78da4545231a3fa9438293dc712a77ded
Reviewed-on: https://chromium-review.googlesource.com/1222148
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590765}
[modify] https://crrev.com/2a5bebd60330cb4b99c6a07d915398d7a04359d2/DEPS

Status: Fixed (was: Assigned)

Sign in to add a comment