Background Tab Resource Load Throttling incorrect wording in warning
Reported by
clon...@yahoo.com.au,
Sep 12
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36 Steps to reproduce the problem: 1. Open some page (eg. www.getpaint.net) 2. Switch to a different tab so the page loads in the background 3. Switch back to the tab when it's finished loading and check the dev tools for the warning message What is the expected behavior? What went wrong? The warning message isn't grammatically correct: "Active resource loading counts reached to a per-frame limit while the tab is in background. Network requests will be delayed until a previous loading finishes, or the tab is foregrounded." In my opinion it should read: "Active resource loading counts reached a per-frame limit while the tab was in the background. Network requests will be delayed until a previous loading finishes, or the tab is brought to the foreground." Did this work before? No Chrome version: 69.0.3497.81 Channel: stable OS Version: 10.0 Flash Version: Yes, I realise this is extremely nit-picky, but should also be extremely easy to fix and if no one reports it it won't be fixed. So... yeah, I'm spending 5 minutes to report this :) Here's what I changed and why I changed it: - Removed the unnecessary "to" --- It was just plain wrong and didn't make sense. - Changed "is" to "was" --- It makes more sense to say "was" than "is" because the limit was reached while the tab was in the background, regardless of whether the tab is still in the background when the message is read. Also, you can only read those messages when the tab is in the foreground (unless you have the devtools undocked) and "is" would make no sense in that case. - Added a "the" for consistency with the other "the" --- It was awkward to read. - Changed "foregrounded" to "brought to the foreground" --- It makes more sense to use a regular phrase than to invent a new word randomly.
,
Sep 14
Thanks, I will fix it soon.
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3cc9e16a25f2c7f0ba2e8ba940e4c74b65b8a90c commit 3cc9e16a25f2c7f0ba2e8ba940e4c74b65b8a90c Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Tue Sep 18 06:20:50 2018 ResourceLoadScheduler: Fix incorrect wording of console info Update the console message. This is based on a user's feedback :) Bug: 883173 Change-Id: I197f44a52b13319e6da96a04bb09792f9dcce2cf Reviewed-on: https://chromium-review.googlesource.com/1226751 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#591956} [modify] https://crrev.com/3cc9e16a25f2c7f0ba2e8ba940e4c74b65b8a90c/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
,
Sep 18
Adjust labels: - This happens across all blink based platforms => Flip bits except for iOS - This should happen from m69 stable => FoundIn-69 - The fix was submitted for m71 => keep Target-71 - And, status should be Fixed now.
,
Sep 19
Able to reproduce this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 17.10 on the reported version 69.0.3497.81 and the issue is fixed on the latest M-71 build 71.0.3556.0. Attached is the screen shot for reference. Hence adding TE verified labels as the fix is working as intended. Thanks.. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ajha@chromium.org
, Sep 13Components: Blink>Loader
Labels: Target-71 M-71 FoundIn-71 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
436 KB
436 KB View Download