New issue
Advanced search Search tips

Issue 883167 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove test-gainnode.html test

Project Member Reported by rtoy@chromium.org, Sep 12

Issue description

Consider rewriting test-gainnode.html using audit.js.  If the test fails it prints out the first point where the difference between the actual and expected result exceeds the threshold.  Which is ok, except if you're changing the test and need to update the threshold. You get to update the threshold basically one element at a time and also manually computing the threshold after each failure.  This is really horrible.

Compare how this would work if we used audit and should().beCloseToArray().  The failed output would show you what the actual max absolute (and relative) error for the test would be so you can just look and set the threshold after running the test just once.

Also, the test doesn't allow any way of updating the expected wav file from the actual output.  That's pretty terrible too.
 
Actually, according to the comment in test-gainnode.html, it's essentially the same test as https://github.com/WebKit/webkit/blob/master/LayoutTests/webaudio/gain.html which was moved for there to WPT as gain.html.

Hence, we should actually just get rid of this test altogether.
Summary: Remove test-gainnode.html test (was: Rewrite test-gainnode.html test)
Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d112ca483c8ef22ff3b910515af6f5ce64e29f08

commit d112ca483c8ef22ff3b910515af6f5ce64e29f08
Author: Raymond Toy <rtoy@chromium.org>
Date: Fri Sep 14 21:51:09 2018

Remove redundant test-gainnode.html test

As noted in the comments in that file, it is essentially the same as
https://github.com/WebKit/webkit/blob/master/LayoutTests/webaudio/gain.html
which was moved from there to WPT as gain.html.  This test is now
basically redundant and adds no additional coverage.

Bug:  883167 
Change-Id: Ie50111e263790025c615b64ad8f5e06428ae3177
Reviewed-on: https://chromium-review.googlesource.com/1221477
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591486}
[delete] https://crrev.com/3a5a4c0143dba99ca0a9e8eba54187c7f8d7e7dc/third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-gainnode-interface/test-gainnode.html

Status: Fixed (was: Started)

Sign in to add a comment