New issue
Advanced search Search tips

Issue 883155 link

Starred by 1 user
Status: Verified
Owner:
kmarshall@chromium.org
Closed: Sep 14
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Improve experience for installing packages for non-standalone executables.

Project Member Reported by kmarshall@chromium.org, Sep 12 
The webrunner and chromium Fuchsia packages export services aren't meant to be run standalone. Installing these packages without accidentally running the packages as standalone executables requires using a nonobvious command line parameter "--install-only". The interface can be improved, e.g. by removing implicit run capabilities for these sorts of packages.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbe87e1ef71b97443ffb32a279f1a98c19d55ba5

commit cbe87e1ef71b97443ffb32a279f1a98c19d55ba5
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed Sep 12 17:31:24 2018

[fuchsia] Mark WebRunner targets as install-only.

The Webrunner packages are meant to be run as service providers, not
as standalone executables. This CL modifies the script generation
logic to generate additional installer scripts, which installs the
package[s] but doesn't run them.

These installer scripts will be written to "OUT_DIR/bin/install_foo".

Runner scripts won't be generated for webrunner service packages
because they aren't supposed to be run as standalone executables.


Bug:  883155 
Change-Id: I766bb76cbae35d654d80142b63994f59dc249ad9
Reviewed-on: https://chromium-review.googlesource.com/1220715
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590741}
[modify] https://crrev.com/cbe87e1ef71b97443ffb32a279f1a98c19d55ba5/build/config/fuchsia/rules.gni
[modify] https://crrev.com/cbe87e1ef71b97443ffb32a279f1a98c19d55ba5/webrunner/BUILD.gn

Comment 2 by kmarshall@chromium.org, Sep 14

Status: Verified (was: Started)
►

Sign in to add a comment