New issue
Advanced search Search tips

Issue 883154 link

Starred by 2 users
Status: Fixed
Owner:
pasko@chromium.org
Closed: Sep 13
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 760498



Sign in to add a comment

startup.mobile benchmark crashes on android-go-perf

Project Member Reported by nednguyen@chromium.org, Sep 12 
Log:
https://chrome-swarming.appspot.com/task?id=3fe324bfb859b710&refresh=10&show_raw=1

(ERROR) 2018-09-11 20:45:34,766 page_test_results.Fail:540  Failure recorded: Error: Number of request starts (0) differs from number of browser starts (10)
    at new androidStartupMetric (/tracing/metrics/android_startup_metric.html:93:13)
    at runMetrics (/b/swarming/w/ir/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:61:16)
    at metricMapFunction (/b/swarming/w/ir/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:190:24)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:39:7)
    at eval (/b/swarming/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
    at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:24:10)
    at mapSingleTraceWithResult (/b/swarming/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:52:12)
    at Object.mapSingleTraceMain (/b/swarming/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:77:20)
    at eval (/b/swarming/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:90:15)
    at Object.loadHTMLFile (/b/swarming/w/ir/third_party/catapult/third_party/vinn/vinn/html_imports_loader.js:140:5)


Pasko@ can you investigate?

Comment 1 by pasko@chromium.org, Sep 12

Status: Started (was: Untriaged)
it is probably because of  http://crbug.com/880129 , removing the metric temporarily: https://chromium-review.googlesource.com/c/catapult/+/1221766
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/67653ff0eab238be24b84d4d97ff424fc6d9ecb2

commit 67653ff0eab238be24b84d4d97ff424fc6d9ecb2
Author: Egor Pasko <pasko@chromium.org>
Date: Wed Sep 12 14:29:55 2018

androidStartupMetric: Remove request_start_time

After http://crrev.com/590429 metrics fail in startup.mobile benchmark.
Temporarily remove the metric.

Bug:  chromium:883154 
TBR=nednguyen@google.com
Change-Id: Ie985baa971c2711cac141a7c4452a67cc2a35307
Reviewed-on: https://chromium-review.googlesource.com/1221766
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/67653ff0eab238be24b84d4d97ff424fc6d9ecb2/tracing/tracing/metrics/android_startup_metric_test.html
[modify] https://crrev.com/67653ff0eab238be24b84d4d97ff424fc6d9ecb2/tracing/tracing/metrics/android_startup_metric.html
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caec1437b7c97bd1a3293454cb6c344d9d09eb8c

commit caec1437b7c97bd1a3293454cb6c344d9d09eb8c
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Sep 12 15:40:00 2018

Roll src/third_party/catapult 134ee369521c..67653ff0eab2 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/134ee369521c..67653ff0eab2


git log 134ee369521c..67653ff0eab2 --date=short --no-merges --format='%ad %ae %s'
2018-09-12 pasko@chromium.org androidStartupMetric: Remove request_start_time


Created with:
  gclient setdep -r src/third_party/catapult@67653ff0eab2

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:883154 
TBR=sullivan@chromium.org

Change-Id: I6baf9c2f745d7e63cf0c354c0f0a4ee246f3769d
Reviewed-on: https://chromium-review.googlesource.com/1221691
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#590691}
[modify] https://crrev.com/caec1437b7c97bd1a3293454cb6c344d9d09eb8c/DEPS

Comment 4 by pasko@chromium.org, Sep 13 

Issue 883653 has been merged into this issue.

Comment 5 by pasko@chromium.org, Sep 13

Status: Fixed (was: Started)
I believe this should get fixed with next Clank roll.
►

Sign in to add a comment