Issue metadata
Sign in to add a comment
|
base_unittests failing for linux-chromeos-rel in the waterfall due to PartitionAllocTest failing |
||||||||||||||||||||||
Issue descriptionSuspect cl: https://chromium-review.googlesource.com/c/chromium/src/+/1220468 Build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/13230 Stack: ../../base/allocator/partition_allocator/partition_alloc_unittest.cc:738: Failure Expected equality of these values: kFreedByte Which is: '\xCD' (205) *(reinterpret_cast<unsigned char*>(new_ptr) + (size - 1)) Which is: '\0' Stack trace: #0 0x000000e50bfc testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x000000e505d9 testing::internal::AssertHelper::operator=() #2 0x000000d530fb base::internal::PartitionAllocTest_GenericAllocSizes_Test::TestBody() [ FAILED ] PartitionAllocTest.GenericAllocSizes (3 ms) [ RUN ] PartitionAllocTest.GenericAllocSizes ../../base/allocator/partition_allocator/partition_alloc_unittest.cc:738: Failure Expected equality of these values: kFreedByte Which is: '\xCD' (205) *(reinterpret_cast<unsigned char*>(new_ptr) + (size - 1)) Which is: '\0' Stack trace: #0 0x000000e50bfc testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x000000e505d9 testing::internal::AssertHelper::operator=()
,
Sep 12
I'll just fold this into the perf regression bug. They'll both be fixed together when I repair the reverted CL tomorrow.
,
Sep 12
Thank you!
,
Sep 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a027d75bf6661b126d95a5032ea45c6ad2a6d0a9 commit a027d75bf6661b126d95a5032ea45c6ad2a6d0a9 Author: Chris Palmer <palmer@chromium.org> Date: Wed Sep 12 20:15:26 2018 [PartitionAlloc] Don't poison memory on free. It seems to have been the cause of a perf regression. This is a re-land of https://chromium-review.googlesource.com/c/chromium/src/+/1220468, with a fixed test: the code and unit tests need to have matching behavior and expectations when `DCHECK_IS_ON()`. Bug: 882471 , 680657 , 883144 Change-Id: I7afb7c8d9f57431dfd4e264a6a22711660e040d6 Reviewed-on: https://chromium-review.googlesource.com/1222290 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#590800} [modify] https://crrev.com/a027d75bf6661b126d95a5032ea45c6ad2a6d0a9/base/allocator/partition_allocator/partition_alloc_unittest.cc [modify] https://crrev.com/a027d75bf6661b126d95a5032ea45c6ad2a6d0a9/base/allocator/partition_allocator/partition_page.h |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by palmer@chromium.org
, Sep 12