New issue
Advanced search Search tips

Issue 883143 link

Starred by 1 user
Status: Fixed
Owner:
tedc...@chromium.org
Closed: Sep 28
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocking:
issue 843596



Sign in to add a comment

Remove LocationBar dependency from SuggestionView

Project Member Reported by tedc...@chromium.org, Sep 12 
SuggestionView relies heavily on the location bar to position itself, but that makes splitting the suggestion logic from the location bar difficult.

First, we should try to rework the suggestion view to not need this or be provided it through a more generic interface.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8684e1fd445741044b7ea1dd1f9493a23b6390f5

commit 8684e1fd445741044b7ea1dd1f9493a23b6390f5
Author: Ted Choc <tedchoc@chromium.org>
Date: Fri Sep 14 18:49:14 2018

Get rid of draw time positioning in SuggestionView.

The previous code would layout each View to be the full
height of the suggestion container and then move them around
at draw time.

BUG= 883143 

Change-Id: I2d25293042395d75608f2b7cc55399edf8518e57
Reviewed-on: https://chromium-review.googlesource.com/1225215
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591414}
[modify] https://crrev.com/8684e1fd445741044b7ea1dd1f9493a23b6390f5/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c0a2f9091dd59b23021d12701f9056a1f74341c

commit 0c0a2f9091dd59b23021d12701f9056a1f74341c
Author: Ted Choc <tedchoc@chromium.org>
Date: Thu Sep 20 23:16:50 2018

Remove LocationBar/UrlBar references from SuggestionView.

This converts the custom view tracking logic with just static/
explicit offsets.  This view no longer is under the crazy development
that made the custom tracking somewhat reasonable.  It is now just
overly complicated and more difficult to reason about.  Phone converted
to static offsets a while ago, so this unifies it with tablets.

BUG= 883143 

Change-Id: I6076501bee54f052a372be97aaab97686f44497b
Reviewed-on: https://chromium-review.googlesource.com/1228985
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592993}
[modify] https://crrev.com/0c0a2f9091dd59b23021d12701f9056a1f74341c/chrome/android/java/res/values-sw600dp/dimens.xml
[modify] https://crrev.com/0c0a2f9091dd59b23021d12701f9056a1f74341c/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/0c0a2f9091dd59b23021d12701f9056a1f74341c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBar.java
[modify] https://crrev.com/0c0a2f9091dd59b23021d12701f9056a1f74341c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/0c0a2f9091dd59b23021d12701f9056a1f74341c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxResultsAdapter.java
[modify] https://crrev.com/0c0a2f9091dd59b23021d12701f9056a1f74341c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestionsList.java
[modify] https://crrev.com/0c0a2f9091dd59b23021d12701f9056a1f74341c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
[modify] https://crrev.com/0c0a2f9091dd59b23021d12701f9056a1f74341c/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java
[modify] https://crrev.com/0c0a2f9091dd59b23021d12701f9056a1f74341c/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

Comment 4 by tedc...@chromium.org, Sep 28

Status: Fixed (was: Assigned)
►

Sign in to add a comment