Activity indicator is not updated appropriately below the app icon on the shelf |
||||||||||||
Issue descriptionChrome OS Version: M70 (11021.12.0, 70.0.3538.15) dev channel eve What steps will reproduce the problem? (1) Open a Gmail web shortcut in browser tab (2) Activity indicator (white hyphen) is shown in Bold below the app icon on shelf (3) Now open a Youtube web shortcut in the same browser window (4) Close Youtube tab What happens instead? Activity indicator (white hyphen) is not updated appropriately on the shelf Expected Behavior? (3) Youtube app must be highlighted with Bold white hyphen below the icon on the shelf (4) Activity indicator is still cached even after closing it
,
Sep 12
Thanks for the report!
,
Sep 12
,
Sep 18
Interaction between indicators and Chrome / tabs / web-apps is a bit fishy and sometimes unpredictable (at least to me)... Punting to M-71.
,
Oct 15
Bulk moving all M-71 <P-1's to M-72.
,
Oct 15
,
Dec 3
Bulk moving <p-1's to the next milestone because we branched to M-73.
,
Dec 18
For the part where the indicator remains after closing the tab, I can't reproduce this right now (tried with Gmail and News). I think it's intended that Chrome shortcuts (that open into a browser window) cause the browser icon to get the "active" indicator. Sébastien, could you confirm that this is working as intended? Then please either mark as "working as intended" or reassign to me :-) Thank you!
,
Dec 18
Assigning to you as the behavior is buggy, as described. To test , install the Youtube and Gmail app from the Chrome Store, pin them to shelf and tap from one tabbed app to the other. You'll notice the activity indicator is really unreliable. What seems to be happening is that the highlight becomes "Active" (white) only when the window is re-opened via the shortcut or minimized and restored again. Otherwise, switching tabs either through Chrome or through pinned shortcut doesn't update the activity highlight. In addition when neither of Youtube nor Gmail app are selected but another tab is, the Chrome icon should be highlighted as active, which it isn't today. See images attached, Chrome was first open via gmail shortcut: In #01, Youtube should be highlighted as active, Gmail is. In #02, Chrome icon should be highlighted as active, New tab being selected.
,
Dec 28
,
Jan 8
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec9110f4862deffb7419d0255d8bc273be7c9809 commit ec9110f4862deffb7419d0255d8bc273be7c9809 Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Wed Jan 09 00:35:17 2019 Update shelf activity indicator for tabbed web app. Currently when a tab activates/deactivates, the updated shelf id is written to the kShelfIDKey window property, but not used on the Ash side until a browser window activates/deactivates. Bug: 883130 Test: ash_unit_tests --gtest_filter=ShelfController* Change-Id: I0f167b41593abb57931f514ecea48ad547ea70cd Reviewed-on: https://chromium-review.googlesource.com/c/1401225 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#620963} [modify] https://crrev.com/ec9110f4862deffb7419d0255d8bc273be7c9809/ash/shelf/shelf_controller_unittest.cc [modify] https://crrev.com/ec9110f4862deffb7419d0255d8bc273be7c9809/ash/shelf/shelf_window_watcher.cc
,
Jan 9
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by mkarkada@chromium.org
, Sep 11