New issue
Advanced search Search tips

Issue 883129 link

Starred by 3 users
Status: Verified
Owner:
joelhockey@chromium.org
Closed: Oct 4
Cc:
ajha@chromium.org
lucmult@chromium.org
weifangsun@chromium.org
fukino@chromium.org
slangley@chromium.org
mkarkada@chromium.org
dhadd...@chromium.org
abod...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Quick view: Html file content is not displayed properly

Project Member Reported by sdantul...@chromium.org, Sep 11 
ChromeOS 11021.12.0, 70.0.3538.15 dev-channel kevin

What steps will reproduce the problem?
1. Save a webpage to Downloads folder
2. Select the file and press spacebar key for QuickView 

What is the expected result?
Html file content should be displayed properly. 

What happens instead?
Html file content is not displayed properly. Background is dark and unable to view the content.

Issue not reproduced on M69 10895.49.0, 69.0.3497.87 beta-channel

Comment 2 by weifangsun@chromium.org, Sep 12

Cc: fukino@chromium.org ajha@chromium.org slangley@chromium.org
 Issue 883235  has been merged into this issue.

Comment 3 by slangley@chromium.org, Sep 12

Owner: lucmult@chromium.org
Status: Assigned (was: Untriaged)
Luciano - can you take a look?

Comment 4 by lucmult@chromium.org, Sep 13

Cc: joelhockey@chromium.org
Owner: joelhockey@chromium.org

Comment 5 by lucmult@chromium.org, Sep 13

Cc: -joelhockey@chromium.org lucmult@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77a41222c8fc0421e2978a29f842869396502d92

commit 77a41222c8fc0421e2978a29f842869396502d92
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri Sep 14 01:03:16 2018

CrOS FilesApp: Add text-content css to quickview html display

UI Test verifies that background for HTML files is set to white
rgb(255, 255, 255).

Bug:  883129 
Change-Id: I2c67d83ddd99db429116a652178019124079f526
Reviewed-on: https://chromium-review.googlesource.com/1223046
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591245}
[modify] https://crrev.com/77a41222c8fc0421e2978a29f842869396502d92/ui/file_manager/file_manager/foreground/elements/files_quick_view.html
[modify] https://crrev.com/77a41222c8fc0421e2978a29f842869396502d92/ui/file_manager/file_manager/test/js/test_util.js
[modify] https://crrev.com/77a41222c8fc0421e2978a29f842869396502d92/ui/file_manager/file_manager/test/quick_view.js

Comment 7 by joelhockey@chromium.org, Sep 14

Status: Fixed (was: Assigned)

Comment 8 by joelhockey@chromium.org, Sep 17

Labels: -Pri-2 Pri-3
Status: Assigned (was: Fixed)
Noel has requested for me to add a test in integration tests similar to the one I added for UI tests.

Comment 9 by slangley@chromium.org, Sep 24

Labels: -M-70 CrOSFilesCategory-Testing M-71

Comment 10 by joelhockey@chromium.org, Oct 4

Status: Fixed (was: Assigned)
Test added by noel@ in https://chromium-review.googlesource.com/c/chromium/src/+/1258670

Comment 11 by abod...@chromium.org, Oct 31

Status: Verified (was: Fixed)
►

Sign in to add a comment