New issue
Advanced search Search tips

Issue 883126 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 19
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 821009



Sign in to add a comment

Migrate syncer::SyncManagerImpl to NetworkConnectionTracker

Project Member Reported by rmcelrath@chromium.org, Sep 11

Issue description

syncer::SyncManagerImpl currently uses net::NetworkChangeNotifier to receive network changes. 

With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.
 
Status: Started (was: Assigned)
Labels: -Proj-Servicification-Stable Hotlist-KnownIssue
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c

commit 206b092e3b7be2aa4f0fc1a77ac95847455d8e5c
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Wed Sep 19 17:34:59 2018

Migrate SyncSchedulerImpl to NetworkConnectionTracker

This migrates SyncSchedulerImpl from NetworkChangeNotifier to
NetworkConnectionTracker, which works with the network service enabled.

Bug:  883126 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I3482c04e6943df0b928eaebd48d9b511c6cb913a
Reviewed-on: https://chromium-review.googlesource.com/1222699
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592459}
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/browser_sync/abstract_profile_sync_service_test.cc
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/browser_sync/profile_sync_test_util.cc
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/BUILD.gn
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/engine/sync_manager_factory.cc
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/engine/sync_manager_factory.h
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/engine/sync_manager_factory_for_profile_sync_test.cc
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/engine/sync_manager_factory_for_profile_sync_test.h
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/engine_impl/DEPS
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/engine_impl/sync_manager_for_profile_sync_test.cc
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/engine_impl/sync_manager_impl.cc
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/engine_impl/sync_manager_impl.h
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/engine_impl/sync_manager_impl_unittest.cc
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/engine_impl/sync_scheduler.h
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/engine_impl/sync_scheduler_impl.cc
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/engine_impl/sync_scheduler_impl.h
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/engine_impl/sync_scheduler_impl_unittest.cc
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/test/engine/fake_sync_scheduler.cc
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/test/engine/fake_sync_scheduler.h
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/tools/BUILD.gn
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/components/sync/tools/sync_client.cc
[modify] https://crrev.com/206b092e3b7be2aa4f0fc1a77ac95847455d8e5c/ios/chrome/browser/sync/profile_sync_service_factory.cc

Status: Fixed (was: Started)

Sign in to add a comment