syncer::GCMNetworkChannel currently uses net::NetworkChangeNotifier to receive network changes. With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf1b468798c64b93c4f66c90566fd5f2145e31e5 commit bf1b468798c64b93c4f66c90566fd5f2145e31e5 Author: Robbie McElrath <rmcelrath@chromium.org> Date: Mon Sep 17 18:57:59 2018 Migrate GCMNetworkChannel to NetworkConnectionTracker This CL migrates GCMNetworkChannel from NetworkChangeNotifier to NetworkConnectionTracker, which works with the network service enabled. Bug: 883125 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id157691c06add22a8a662ee5d40d244eb73b8e58 Reviewed-on: https://chromium-review.googlesource.com/1222888 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#591757} [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl.cc [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/chrome/browser/invalidation/deprecated_profile_invalidation_provider_factory.cc [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/components/invalidation/impl/gcm_network_channel.cc [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/components/invalidation/impl/gcm_network_channel.h [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/components/invalidation/impl/gcm_network_channel_unittest.cc [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/components/invalidation/impl/non_blocking_invalidator.cc [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/components/invalidation/impl/non_blocking_invalidator.h [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/components/invalidation/impl/sync_system_resources.cc [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/components/invalidation/impl/sync_system_resources.h [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/components/invalidation/impl/ticl_invalidation_service.cc [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/components/invalidation/impl/ticl_invalidation_service.h [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/components/invalidation/impl/ticl_invalidation_service_unittest.cc [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/components/invalidation/impl/ticl_profile_settings_provider_unittest.cc [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/ios/chrome/browser/invalidation/BUILD.gn [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.mm [modify] https://crrev.com/bf1b468798c64b93c4f66c90566fd5f2145e31e5/ios/web_view/internal/sync/web_view_profile_invalidation_provider_factory.mm
Comment 1 by rmcelrath@chromium.org
, Sep 12