policy::CloudPolicyRefreshScheduler currently uses net::NetworkChangeNotifier to receive network changes. With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f633990e5a9c2d0ec83218f683b43a428afa345f commit f633990e5a9c2d0ec83218f683b43a428afa345f Author: Robbie McElrath <rmcelrath@chromium.org> Date: Tue Oct 02 21:44:48 2018 Migrate CloudPolicyRefreshScheduler to NetworkConnectionTracker This CL migrates CloudPolicyRefreshScheduler from NetworkChangeNotifier to NetworkConnectionTracker, which works with the network service enabled. Bug: 883124 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I455250e60d94347da2fcb8ecc752dbf958bc2abd Reviewed-on: https://chromium-review.googlesource.com/c/1220241 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#595993} [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/chrome/browser/chromeos/policy/affiliated_cloud_policy_invalidator_unittest.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/chrome/browser/chromeos/policy/device_local_account_policy_service.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/chrome/browser/policy/cloud/machine_level_user_cloud_policy_browsertest.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/chrome/browser/policy/machine_level_user_cloud_policy_controller.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/chrome/browser/policy/profile_policy_connector_unittest.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/cloud_policy_core.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/cloud_policy_core.h [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/cloud_policy_core_unittest.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/cloud_policy_manager.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/cloud_policy_manager.h [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/cloud_policy_manager_unittest.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/cloud_policy_refresh_scheduler_unittest.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/machine_level_user_cloud_policy_manager.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/machine_level_user_cloud_policy_manager.h [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/machine_level_user_cloud_policy_manager_unittest.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/user_cloud_policy_manager.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/user_cloud_policy_manager.h [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/components/policy/core/common/cloud/user_cloud_policy_manager_unittest.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/content/browser/network_service_instance.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/content/public/browser/network_service_instance.h [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/services/network/public/cpp/network_connection_tracker.h [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/services/network/test/test_network_connection_tracker.cc [modify] https://crrev.com/f633990e5a9c2d0ec83218f683b43a428afa345f/services/network/test/test_network_connection_tracker.h
Comment 1 by rmcelrath@chromium.org
, Sep 12