New issue
Advanced search Search tips

Issue 883123 link

Starred by 1 user
Status: Fixed
Owner:
jzw@chromium.org
Closed: Oct 12
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Translate failures are reported as success

Project Member Reported by jzw@chromium.org, Sep 11 
In IOSTranslateDriver's method OnTranslateComplete, it should early return if there's an error instead of going on and calling TranslationDidSucceed.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cff319575f64f7de8907c958d5e24bebfca85cc7

commit cff319575f64f7de8907c958d5e24bebfca85cc7
Author: John Z Wu <jzw@chromium.org>
Date: Wed Sep 12 16:01:19 2018

Early return on translate error.

It seems this was missing before.

Bug:  883123 
Change-Id: Ic9f12b5b572a0e2681f671d34be7db3afb7e18a8
Reviewed-on: https://chromium-review.googlesource.com/1220045
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590704}
[modify] https://crrev.com/cff319575f64f7de8907c958d5e24bebfca85cc7/components/translate/ios/browser/ios_translate_driver.mm

Comment 2 by jzw@chromium.org, Oct 12

Status: Fixed (was: Assigned)
►

Sign in to add a comment