New issue
Advanced search Search tips

Issue 883120 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 821009



Sign in to add a comment

Migrate local_discovery::ServiceDiscoveryClientMdns to NetworkConnectionTracker

Project Member Reported by rmcelrath@chromium.org, Sep 11

Issue description

local_discovery::ServiceDiscoveryClientMdns currently uses net::NetworkChangeNotifier to receive network changes. 

With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.
 
Status: Started (was: Assigned)
Labels: -Proj-Servicification-Stable Hotlist-KnownIssue
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d675c2f0271be788ce56d1f89cccc3ec33fb2a7

commit 3d675c2f0271be788ce56d1f89cccc3ec33fb2a7
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Sat Sep 15 00:32:19 2018

Migrate ServiceDiscoveryClientMdns to NetworkConnectionTracker

This migrates ServiceDiscoveryClientMdns from NetworkChangeNotifier
to NetworkConnectionTracker, which is needed for it to work with the
network service enabled.

Bug:  883120 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I910b7987d849c2e66565a774937086382ba6f7e5
Reviewed-on: https://chromium-review.googlesource.com/1220808
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591538}
[modify] https://crrev.com/3d675c2f0271be788ce56d1f89cccc3ec33fb2a7/chrome/browser/local_discovery/service_discovery_client_mdns.cc
[modify] https://crrev.com/3d675c2f0271be788ce56d1f89cccc3ec33fb2a7/chrome/browser/local_discovery/service_discovery_client_mdns.h

Status: Fixed (was: Started)

Sign in to add a comment