New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 883119 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 883059
Owner:
Last visit > 30 days ago
Closed: Sep 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: ----
Type: Bug-Security



Sign in to add a comment

Use-after-poison in v8::internal::Call::GetCallType

Project Member Reported by ClusterFuzz, Sep 11

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6492031176933376

Fuzzer: mbarbella_js_mutation
Job Type: windows_asan_d8
Platform Id: windows

Crash Type: Use-after-poison READ 2
Crash Address: 0x117da1a054f8
Crash State:
  v8::internal::Call::GetCallType
  v8::internal::interpreter::BytecodeGenerator::VisitCall
  v8::internal::interpreter::BytecodeGenerator::VisitNoStackOverflowCheck
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8&range=55800:55801

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6492031176933376

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 11

Components: Blink>JavaScript>Interpreter
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Sep 11

Labels: Test-Predator-Auto-Owner
Owner: sattlerf@google.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/78f8ff95680c928e3842e75c59ebd17b7ed64c5c ([preparser] Refactor VariableProxies to use ThreadedLists interface).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Mergedinto: 883059
Status: Duplicate (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/daf1a349dc38da3617263cd6461be2cb377d28ae

commit daf1a349dc38da3617263cd6461be2cb377d28ae
Author: Florian Sattler <sattlerf@google.com>
Date: Wed Sep 12 09:10:05 2018

Revert "[preparser] Refactor VariableProxies to use ThreadedLists interface"

This reverts commit 78f8ff95680c928e3842e75c59ebd17b7ed64c5c.

Reason for revert: Causing failures on ClusterFuzz and flakes on the waterfall.
BUG:  v8:8166 ,  chromium:883042 ,  chromium:883054 ,  chromium:883119 ,  chromium:883110 

Original change's description:
> [preparser] Refactor VariableProxies to use ThreadedLists interface
>
> Bug:  v8:7926 ,
> Change-Id: Idfc520b67696c8a838a0ee297ea392d416dd899e
> Reviewed-on: https://chromium-review.googlesource.com/1206292
> Commit-Queue: Florian Sattler <sattlerf@google.com>
> Reviewed-by: Igor Sheludko <ishell@chromium.org>
> Reviewed-by: Marja Hölttä <marja@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#55801}

TBR=marja@chromium.org,cbruni@chromium.org,ishell@chromium.org,verwaest@chromium.org,sattlerf@google.com

Change-Id: Ibebff76b5ae69b9790b73c6bd1d53beff5d53673
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  v8:7926 
Reviewed-on: https://chromium-review.googlesource.com/1221227
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55819}
[modify] https://crrev.com/daf1a349dc38da3617263cd6461be2cb377d28ae/BUILD.gn
[modify] https://crrev.com/daf1a349dc38da3617263cd6461be2cb377d28ae/src/ast/ast.h
[delete] https://crrev.com/0005c2de36641830a390a4e9943a7671262ec7f0/src/ast/scopes-inl.h
[modify] https://crrev.com/daf1a349dc38da3617263cd6461be2cb377d28ae/src/ast/scopes.cc
[modify] https://crrev.com/daf1a349dc38da3617263cd6461be2cb377d28ae/src/ast/scopes.h
[modify] https://crrev.com/daf1a349dc38da3617263cd6461be2cb377d28ae/src/parsing/preparser.h
[modify] https://crrev.com/daf1a349dc38da3617263cd6461be2cb377d28ae/src/utils.h
[modify] https://crrev.com/daf1a349dc38da3617263cd6461be2cb377d28ae/test/unittests/BUILD.gn
[delete] https://crrev.com/0005c2de36641830a390a4e9943a7671262ec7f0/test/unittests/utils/threaded-list.cc

Project Member

Comment 5 by ClusterFuzz, Sep 13

ClusterFuzz has detected this issue as fixed in range 55818:55819.

Detailed report: https://clusterfuzz.com/testcase?key=6492031176933376

Fuzzer: mbarbella_js_mutation
Job Type: windows_asan_d8
Platform Id: windows

Crash Type: Use-after-poison READ 2
Crash Address: 0x117da1a054f8
Crash State:
  v8::internal::Call::GetCallType
  v8::internal::interpreter::BytecodeGenerator::VisitCall
  v8::internal::interpreter::BytecodeGenerator::VisitNoStackOverflowCheck
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8&range=55800:55801
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_d8&range=55818:55819

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6492031176933376

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 21

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment